On Mon, Aug 24, 2009 at 12:32 PM, Jerry James<james(a)xemacs.org> wrote:
On Wed, Jul 15, 2009 at 9:16 AM, Vin
> malloc takes a size_t. Here are the sizes of the respective types:
> sizeof(int) = 4
> sizeof(long) = 4
> sizeof(size_t) = 4
Sorry to take so long with this. My 2 week vacation put me so far
behind at work that it's taken me awhile to get around to all the bug
reports that piled up for me while I was gone. It's a good thing I
was able to relax for 2 weeks first! (NB: I had 4 children with me on
vacation, which should tell you something about how much relaxing I
got to do.)
We need to deal with two issues. First is the missing (U)INT_64_BIT
definition. Thanks for the pointer, Aidan. From looking at that, as
well as a few other remarks about __int64 located with Google, it
appears that this issue affects 32-bit Windows platforms exclusively.
I think we can probably get away with just checking for __WIN32__,
rather than piling on check after check for particular compilers on
Second is the warning. Since we already check that the results of the
image size calculation fit into a size_t, the only real problem here
is that I forgot to cast to a size_t in one place.
So I think this patch fixes both issues. Can somebody try it and tell
me yea or nay?
Thanks for investigating. I tried your latest patch and found that I
had to change __WIN32__ to WIN32_NATIVE (in src/lisp.h) or else I got:
C2065: 'UINT_64_BIT' : undeclared identifier
C2146: syntax error : missing ';' before identifier 'pixels_sq'
XEmacs-Patches mailing list