5:32 p.m.
This incorporates an upstream change I made to
Gnus--cf.
http://quimby.gnus.org/cgi-bin/cvsweb.cgi/gnus/lisp/mm-util.el.diff?r1=6....
, http://tinyurl.com/46rzs , together with a non-nil default for
mm-coding-system-priorities, which is an ordered list of preferred MIME
character sets for a message.
xemacs-packages/gnus/ChangeLog addition:
2005-02-27 Aidan Kehoe <kehoea(a)parhasard.net>
* lisp/mm-util.el (mm-coding-system-priorities):
Give it a non-nil default value even when we're not in Japan,
containing the UTF-8 character set if that's available.
* lisp/mm-util.el (mm-xemacs-find-mime-charset-1): New.
* lisp/mm-util.el (mm-xemacs-find-mime-charset): New.
* lisp/mm-util.el (mm-find-mime-charset-region):
Incorporate upstream XEmacs-specific changes, use latin-unity to
work out which MIME character set is appropriate.
These two changes eliminate the "needs to be split into N charset
parts. Really post?" bug on the default configuration.
XEmacs Packages source patch:
Diff command: cvs -q diff -u
Files affected: xemacs-packages/gnus/lisp/mm-util.el
Index: xemacs-packages/gnus/lisp/mm-util.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/gnus/lisp/mm-util.el,v
retrieving revision 1.5
diff -u -u -r1.5 mm-util.el
--- xemacs-packages/gnus/lisp/mm-util.el 2004/09/28 02:21:14 1.5
+++ xemacs-packages/gnus/lisp/mm-util.el 2005/02/27 16:18:47
＠＠ -304,7 +304,11 ＠＠
(cond ((string= lang "Japanese")
;; Japanese users may prefer iso-2022-jp to shift-jis.
'(iso-2022-jp iso-2022-jp-2 japanese-shift-jis
- iso-latin-1 utf-8)))))
+ iso-latin-1 utf-8))
+ ((find-coding-system 'utf-8)
+ '(iso-8859-1 iso-8859-2 iso-8859-15 utf-8))
+ (t
+ '(iso-8859-1 iso-8859-2 iso-8859-15 iso-2022-jp)))))
"Preferred coding systems for encoding outgoing messages.
More than one suitable coding system may be found for some text.
＠＠ -539,6 +543,83 ＠＠
(> (length (memq a priorities))
(length (memq b priorities)))))
+(eval-when-compile
+ (autoload 'latin-unity-massage-name "latin-unity")
+ (autoload 'latin-unity-maybe-remap "latin-unity")
+ (autoload 'latin-unity-representations-feasible-region "latin-unity")
+ (autoload 'latin-unity-representations-present-region "latin-unity")
+ (defvar latin-unity-coding-systems)
+ (defvar latin-unity-ucs-list))
+
+(defun mm-xemacs-find-mime-charset-1 (begin end)
+ "Determine which MIME charset to use to send region as message.
+This uses the XEmacs-specific latin-unity package to better handle the
+case where identical characters from diverse ISO-8859-? character sets
+can be encoded using a single one of the corresponding coding systems.
+
+It treats `mm-coding-system-priorities' as the list of preferred
+coding systems; a useful example setting for this list in Western
+Europe would be '(iso-8859-1 iso-8859-15 utf-8), which would default
+to the very standard Latin 1 coding system, and only move to coding
+systems that are less supported as is necessary to encode the
+characters that exist in the buffer.
+
+Latin Unity doesn't know about those non-ASCII Roman characters that
+are available in various East Asian character sets. As such, its
+behavior if you have a JIS 0212 LATIN SMALL LETTER A WITH ACUTE in a
+buffer and it can otherwise be encoded as Latin 1, won't be ideal.
+But this is very much a corner case, so don't worry about it."
+ (let ((systems mm-coding-system-priorities) csets psets curset)
+
+ ;; Load the Latin Unity library, if available.
+ (when (and (not (featurep 'latin-unity)) (locate-library
"latin-unity"))
+ (require 'latin-unity))
+
+ ;; Now, can we use it?
+ (if (featurep 'latin-unity)
+ (progn
+ (setq csets (latin-unity-representations-feasible-region begin end)
+ psets (latin-unity-representations-present-region begin end))
+
+ (catch 'done
+
+ ;; Pass back the first coding system in the preferred list
+ ;; that can encode the whole region.
+ (dolist (curset systems)
+ (setq curset (latin-unity-massage-name 'buffer-default curset))
+
+ ;; If the coding system is a universal coding system, then
+ ;; it can certainly encode all the characters in the region.
+ (if (memq curset latin-unity-ucs-list)
+ (throw 'done (list curset)))
+
+ ;; If a coding system isn't universal, and isn't in
+ ;; the list that latin unity knows about, we can't
+ ;; decide whether to use it here. Leave that until later
+ ;; in `mm-find-mime-charset-region' function, whence we
+ ;; have been called.
+ (unless (memq curset latin-unity-coding-systems)
+ (throw 'done nil))
+
+ ;; Right, we know about this coding system, and it may
+ ;; conceivably be able to encode all the characters in
+ ;; the region.
+ (if (latin-unity-maybe-remap begin end curset csets psets t)
+ (throw 'done (list curset))))
+
+ ;; Can't encode using anything from the
+ ;; `mm-coding-system-priorities' list.
+ ;; Leave `mm-find-mime-charset' to do most of the work.
+ nil))
+
+ ;; Right, latin unity isn't available; let `mm-find-charset-region'
+ ;; take its default action, which equally applies to GNU Emacs.
+ nil)))
+
+(defmacro mm-xemacs-find-mime-charset (begin end)
+ (when (featurep 'xemacs)
+ `(mm-xemacs-find-mime-charset-1 ,begin ,end)))
+
(defun mm-find-mime-charset-region (b e &optional hack-charsets)
"Return the MIME charsets needed to encode the region between B and E.
nil means ASCII, a single-element list represents an appropriate MIME
＠＠ -580,8 +661,12 ＠＠
(setq systems nil
charsets (list cs))))))
charsets))
- ;; Otherwise we're not multibyte, we're XEmacs, or a single
- ;; coding system won't cover it.
+ ;; If we're XEmacs, and some coding system is appropriate,
+ ;; mm-xemacs-find-mime-charset will return an appropriate list.
+ ;; Otherwise, we'll get nil, and the next setq will get invoked.
+ (setq charsets (mm-xemacs-find-mime-charset b e))
+
+ ;; We're not multibyte, or a single coding system won't cover it.
(setq charsets
(mm-delete-duplicates
(mapcar 'mm-mime-charset
--
“I, for instance, am gung-ho about open source because my family is being
held hostage in Rob Malda’s basement. But who fact-checks me, or Enderle,
when we say something in public? No-one!” -- Danny O’Brien
10:19 p.m.
* Aidan Kehoe <kehoea(a)parhasard.net> writes:
xemacs-packages/gnus/ChangeLog addition:
2005-02-27 Aidan Kehoe <kehoea(a)parhasard.net>
* lisp/mm-util.el (mm-coding-system-priorities):
Give it a non-nil default value even when we're not in Japan,
containing the UTF-8 character set if that's available.
* lisp/mm-util.el (mm-xemacs-find-mime-charset-1): New.
* lisp/mm-util.el (mm-xemacs-find-mime-charset): New.
* lisp/mm-util.el (mm-find-mime-charset-region):
Incorporate upstream XEmacs-specific changes, use latin-unity to
work out which MIME character set is appropriate.
These two changes eliminate the "needs to be split into N
charset
parts. Really post?" bug on the default configuration.
Thanks for the patch. I'll look at it as soon as I get the chance.
You mentioned that you've made these changes to the Gnus upstream
sources (I don't remember seeing it), was it just to No Gnus or did
they go into the 5.10 branch also?
--
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
| In space, |
| No one can hear you rip a stinky |
|------------------------------------<steve(a)sxemacs.org>---|
10:49 p.m.
Ar an t-ochtú lá is fiche de mí Feabhra, scríobh Steve Youngs:
Thanks for the patch. I'll look at it as soon as I get the
chance.
I appreciate it.
You mentioned that you've made these changes to the Gnus
upstream
sources (I don't remember seeing it), was it just to No Gnus or did
they go into the 5.10 branch also?
The mm-xemacs-find-mime-charset functionality is in the 5.10 branch in CVS,
yeah. I haven’t yet sent them a patch to change the default value of
mm-coding-system-priorities.
--
“I, for instance, am gung-ho about open source because my family is being
held hostage in Rob Malda’s basement. But who fact-checks me, or Enderle,
when we say something in public? No-one!” -- Danny O’Brien
1:19 a.m.
New subject: [V] Re: [PATCH] Saner MIME character set defaults in Gnus.
VETO
* Aidan Kehoe <kehoea(a)parhasard.net> writes:
+(eval-when-compile
+ (autoload 'latin-unity-massage-name "latin-unity")
+ (autoload 'latin-unity-maybe-remap "latin-unity")
+ (autoload 'latin-unity-representations-feasible-region "latin-unity")
+ (autoload 'latin-unity-representations-present-region "latin-unity")
+ (defvar latin-unity-coding-systems)
+ (defvar latin-unity-ucs-list))
This scares the shit out of me. How is this a good thing? How will
PUI + non-Mule XEmacsen cope with this?
This change means the Gnus package will have a dependence on the
latin-unity package.[1] That means that when someone running a non-Mule
XEmacsen tries to do the right thing in PUI and selects to
install/upgrade their Gnus package and then hits `r' to "Add Required
Packages", PUI will dutifully add latin-unity. The problem with that
is that non-Mule XEmacsen _CANNOT_ install mule packages.
And what about people trying to build packages with a non-Mule XEmacs?
They'll lose too. They won't be able to build Gnus because
`BUILD_WITHOUT_MULE' will be `t' and they won't have access to the
latin-unity package.
And aren't latin-unity/mule-ucs a big no no for 21.5? Maybe it's just
mule-ucs, I'm not sure?
I'm sorry, Aiden, but I just can't see how I can accept this patch in
its current state.
It _might_ be possible if those autoloads are wrapped in...
(when (featurep 'mule)
...)
And then in the Makefile...
ifeq ($(BUILD_WITHOUT_MULE),)
REQUIRES += latin-unity
endif
Yes, that could work, I think. Aiden, how does that sit with you?
Footnotes:
[1] Yes I see it is a compile-time dependence and not a run-time one,
but PUI doesn't make that distinction.
--
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
| I am Dyslexic of Borg. |
| Fusistance is retile. Your arse will be laminated. |
|------------------------------------<steve(a)sxemacs.org>---|
11:31 a.m.
New subject: [V] Re: [PATCH] Saner MIME character set defaults in Gnus.
Ar an triú lá déag de mí Márta, scríobh Steve Youngs:
VETO
* Aidan Kehoe <kehoea(a)parhasard.net> writes:
> +(eval-when-compile
> + (autoload 'latin-unity-massage-name "latin-unity")
> + (autoload 'latin-unity-maybe-remap "latin-unity")
> + (autoload 'latin-unity-representations-feasible-region
"latin-unity")
> + (autoload 'latin-unity-representations-present-region
"latin-unity")
> + (defvar latin-unity-coding-systems)
> + (defvar latin-unity-ucs-list))
This scares the shit out of me. How is this a good thing? How will
PUI + non-Mule XEmacsen cope with this?
Everything inside that eval-when-compile is there to shut up the byte
compiler. You can take it all out, the patch works fine. You can compile the
thing with a non-Mule XEmacs, or with a XEmacs which doesn’t have the
latin-unity package available, and the patch works fine. latin-unity is
still checked for at runtime, and used if available.
When Katsumi Yamaoka added that clause, he should perhaps have added a
comment to the effect that that eval-when-compile was only to shut up the
byte compiler.
This change means the Gnus package will have a dependence on the
latin-unity package.[1]
Only if you add that dependency. Otherwise, it’ll build and install fine
without latin-unity or Mule being available.
[...]
--
“I, for instance, am gung-ho about open source because my family is being
held hostage in Rob Malda’s basement. But who fact-checks me, or Enderle,
when we say something in public? No-one!” -- Danny O’Brien
6:19 p.m.
New subject: [Q] Re: [V] Re: [PATCH] Saner MIME character set defaults in Gnus.
QUERY
Aidan, I think the runtime use of mule packages should not be
conditionalized on their availability, but rather on whether the
running XEmacs has (featurep 'mule) available.
I built myself a non-MULE cvs HEAD XEmacs and can't send mail with it,
because of this:
Best regards,
Adrian
Aidan Kehoe <kehoea(a)parhasard.net> writes:
Ar an triú lá déag de mí Márta, scríobh Steve Youngs:
> VETO
>
> * Aidan Kehoe <kehoea(a)parhasard.net> writes:
>
> > +(eval-when-compile
> > + (autoload 'latin-unity-massage-name "latin-unity")
> > + (autoload 'latin-unity-maybe-remap "latin-unity")
> > + (autoload 'latin-unity-representations-feasible-region
"latin-unity")
> > + (autoload 'latin-unity-representations-present-region
"latin-unity")
> > + (defvar latin-unity-coding-systems)
> > + (defvar latin-unity-ucs-list))
>
> This scares the shit out of me. How is this a good thing? How will
> PUI + non-Mule XEmacsen cope with this?
Everything inside that eval-when-compile is there to shut up the byte
compiler. You can take it all out, the patch works fine. You can compile the
thing with a non-Mule XEmacs, or with a XEmacs which doesn~t have the
latin-unity package available, and the patch works fine. latin-unity is
still checked for at runtime, and used if available.
When Katsumi Yamaoka added that clause, he should perhaps have added a
comment to the effect that that eval-when-compile was only to shut up the
byte compiler.
> This change means the Gnus package will have a dependence on the
> latin-unity package.[1]
Only if you add that dependency. Otherwise, it~ll build and install fine
without latin-unity or Mule being available.
> [...]
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
8:13 p.m.
New subject: [PATCH] Only do GNUS Mule character-set lookups when Mule is available.
Ar an naoú lá déag de mí Márta, scríobh Adrian Aichner:
Aidan, I think the runtime use of mule packages should not be
conditionalized on their availability, but rather on whether the
running XEmacs has (featurep 'mule) available.
Well, both on their availability, and whether we’re running on a Mule
build. Thank you for the pointer!
xemacs-packages/gnus/ChangeLog addition:
2005-03-19 Aidan Kehoe <kehoea(a)parhasard.net>
* lisp/mm-util.el (mm-xemacs-find-mime-charset): Only do the Mule
coding system lookup if Mule is available.
XEmacs Packages source patch:
Diff command: cvs -q diff -u
Files affected: xemacs-packages/gnus/lisp/mm-util.el
Index: xemacs-packages/gnus/lisp/mm-util.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/gnus/lisp/mm-util.el,v
retrieving revision 1.7
diff -u -u -r1.7 mm-util.el
--- xemacs-packages/gnus/lisp/mm-util.el 2005/03/14 02:26:20 1.7
+++ xemacs-packages/gnus/lisp/mm-util.el 2005/03/19 19:07:11
＠＠ -654,7 +654,7 ＠＠
nil)))
(defmacro mm-xemacs-find-mime-charset (begin end)
- (when (featurep 'xemacs)
+ (when (and (featurep 'xemacs) (featurep 'mule))
`(mm-xemacs-find-mime-charset-1 ,begin ,end)))
(defun mm-find-mime-charset-region (b e &optional hack-charsets)
--
“I, for instance, am gung-ho about open source because my family is being
held hostage in Rob Malda’s basement. But who fact-checks me, or Enderle,
when we say something in public? No-one!” -- Danny O’Brien
8:38 p.m.
New subject: [Q] Re: [PATCH] Only do GNUS Mule character-set lookups when Mule is available.
QUERY
Aidan Kehoe <kehoea(a)parhasard.net> writes:
Ar an naoú lá déag de mà Márta, scrÃobh Adrian Aichner:
> Aidan, I think the runtime use of mule packages should not be
> conditionalized on their availability, but rather on whether the
> running XEmacs has (featurep 'mule) available.
Well, both on their availability, and whether weâre running on a Mule
Ah, but of
course. I need to semant-check my sentences.
This, however, won't work when
(defmacro mm-xemacs-find-mime-charset (begin end)
(when (and (featurep 'xemacs) (featurep 'mule))
`(mm-xemacs-find-mime-charset-1 ,begin ,end)))
is compiled by an XEmacs with Mule, which is the case for all
officially distributed XEmacs packages, AFAIK.
I'm writing this from a non-Mule XEmacs, and C-c C-c
(message-send-and-exit) gives:
When I recompile mm-util.el in this non-Mule XEamcs I can send the
email, demonstrating this patch cannot be the solution.
Adrian
build. Thank you for the pointer!
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
10:33 p.m.
New subject: [PATCH] Check Mule availability at runtime
Ar an naoú lá déag de mí Márta, scríobh Adrian Aichner:
This, however, won't work when
(defmacro mm-xemacs-find-mime-charset (begin end)
(when (and (featurep 'xemacs) (featurep 'mule))
`(mm-xemacs-find-mime-charset-1 ,begin ,end)))
is compiled by an XEmacs with Mule, which is the case for all
officially distributed XEmacs packages, AFAIK.
Note to self; don’t ever trust the Gnus people to test any XEmacs
changes. Okay, then, I’ve tested the below locally with a non-Mule
build. Does it work for you?
xemacs-packages/gnus/ChangeLog addition:
2005-03-19 Aidan Kehoe <kehoea(a)parhasard.net>
* lisp/mm-util.el (mm-xemacs-find-mime-charset): Only call
mm-xemacs-find-mime-charset-1 if we have the mule feature
available at runtime.
XEmacs Packages source patch:
Diff command: cvs -q diff -u
Files affected: xemacs-packages/gnus/lisp/mm-util.el
Index: xemacs-packages/gnus/lisp/mm-util.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/gnus/lisp/mm-util.el,v
retrieving revision 1.7
diff -u -u -r1.7 mm-util.el
--- xemacs-packages/gnus/lisp/mm-util.el 2005/03/14 02:26:20 1.7
+++ xemacs-packages/gnus/lisp/mm-util.el 2005/03/19 21:25:26
＠＠ -655,7 +655,7 ＠＠
(defmacro mm-xemacs-find-mime-charset (begin end)
(when (featurep 'xemacs)
- `(mm-xemacs-find-mime-charset-1 ,begin ,end)))
+ `(and (featurep 'mule) mm-xemacs-find-mime-charset-1 ,begin ,end)))
(defun mm-find-mime-charset-region (b e &optional hack-charsets)
"Return the MIME charsets needed to encode the region between B and E.
--
“I, for instance, am gung-ho about open source because my family is being
held hostage in Rob Malda’s basement. But who fact-checks me, or Enderle,
when we say something in public? No-one!” -- Danny O’Brien
9:49 p.m.
New subject: [PATCH] Check Mule availability at runtime
Aidan Kehoe <kehoea(a)parhasard.net> writes:
XEmacs Packages source patch:
Diff command: cvs -q diff -u
Files affected: xemacs-packages/gnus/lisp/mm-util.el
Index: xemacs-packages/gnus/lisp/mm-util.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/gnus/lisp/mm-util.el,v
retrieving revision 1.7
diff -u -u -r1.7 mm-util.el
--- xemacs-packages/gnus/lisp/mm-util.el 2005/03/14 02:26:20 1.7
+++ xemacs-packages/gnus/lisp/mm-util.el 2005/03/19 21:25:26
＠＠ -655,7 +655,7 ＠＠
(defmacro mm-xemacs-find-mime-charset (begin end)
(when (featurep 'xemacs)
- `(mm-xemacs-find-mime-charset-1 ,begin ,end)))
+ `(and (featurep 'mule) mm-xemacs-find-mime-charset-1 ,begin ,end)))
Looks wrong to me.
+ `(and (featurep 'mule) (mm-xemacs-find-mime-charset-1 ,begin ,end)))
might work better, but I haven't tested this yet.
Adrian
(defun mm-find-mime-charset-region (b e &optional hack-charsets)
"Return the MIME charsets needed to encode the region between B and E.
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
9:52 p.m.
New subject: [PATCH] Check Mule availability at runtime
Ar an naoú lá déag de mí Márta, scríobh Adrian Aichner:
Looks wrong to me.
Nnngh. Indeed it is. I’m severely surprised that even compiled for me.
+ `(and (featurep 'mule) (mm-xemacs-find-mime-charset-1 ,begin
,end)))
might work better, but I haven't tested this yet.
Test it, and send a patch, if you have a source tree handy.
--
“I, for instance, am gung-ho about open source because my family is being
held hostage in Rob Malda’s basement. But who fact-checks me, or Enderle,
when we say something in public? No-one!” -- Danny O’Brien
9:25 a.m.
New subject: [PATCH] Check Mule availability at runtime
Aidan Kehoe <kehoea(a)parhasard.net> writes:
Ar an naoú lá déag de mí Márta, scríobh Adrian Aichner:
> Looks wrong to me.
Nnngh. Indeed it is. I~m severely surprised that even compiled for me.
Sure, parens match up, it just doesn't do what you wanted it to do :-)
> + `(and (featurep 'mule) (mm-xemacs-find-mime-charset-1 ,begin ,end)))
>
> might work better, but I haven't tested this yet.
Test it, and send a patch, if you have a source tree handy.
Long done, and commited by Steve.
We (or at least I) seem to have severe mail delivery lags (between
tux.org and t-online.de)!
I only got this and Hrvoje's message under an hour ago!
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
10:12 p.m.
New subject: [S] Re: [PATCH] Check Mule availability at runtime
SUPERSEDES <16956.43223.980860.469559(a)parhasard.net>
Aidan, I'd suggest this one instead, with your ChangeLog.
Index: mm-util.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/gnus/lisp/mm-util.el,v
retrieving revision 1.7
diff -u -u -r1.7 mm-util.el
--- mm-util.el 14 Mar 2005 02:26:20 -0000 1.7
+++ mm-util.el 19 Mar 2005 22:04:57 -0000
＠＠ -655,7 +655,7 ＠＠
(defmacro mm-xemacs-find-mime-charset (begin end)
(when (featurep 'xemacs)
- `(mm-xemacs-find-mime-charset-1 ,begin ,end)))
+ `(and (featurep 'mule) (mm-xemacs-find-mime-charset-1 ,begin ,end))))
(defun mm-find-mime-charset-region (b e &optional hack-charsets)
"Return the MIME charsets needed to encode the region between B and E.
I compiled under Mule and sent an e-mail in Mule and non-Mule XEmacs.
Adrian
Aidan Kehoe <kehoea(a)parhasard.net> writes:
Ar an naoú lá déag de mà Márta, scrÃobh Adrian Aichner:
> This, however, won't work when
> (defmacro mm-xemacs-find-mime-charset (begin end)
> (when (and (featurep 'xemacs) (featurep 'mule))
> `(mm-xemacs-find-mime-charset-1 ,begin ,end)))
> is compiled by an XEmacs with Mule, which is the case for all
> officially distributed XEmacs packages, AFAIK.
Note to self; donât ever trust the Gnus people to test any XEmacs
changes. Okay, then, Iâve tested the below locally with a non-Mule
build. Does it work for you?
xemacs-packages/gnus/ChangeLog addition:
2005-03-19 Aidan Kehoe <kehoea(a)parhasard.net>
* lisp/mm-util.el (mm-xemacs-find-mime-charset): Only call
mm-xemacs-find-mime-charset-1 if we have the mule feature
available at runtime.
XEmacs Packages source patch:
Diff command: cvs -q diff -u
Files affected: xemacs-packages/gnus/lisp/mm-util.el
Index: xemacs-packages/gnus/lisp/mm-util.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/gnus/lisp/mm-util.el,v
retrieving revision 1.7
diff -u -u -r1.7 mm-util.el
--- xemacs-packages/gnus/lisp/mm-util.el 2005/03/14 02:26:20 1.7
+++ xemacs-packages/gnus/lisp/mm-util.el 2005/03/19 21:25:26
＠＠ -655,7 +655,7 ＠＠
(defmacro mm-xemacs-find-mime-charset (begin end)
(when (featurep 'xemacs)
- `(mm-xemacs-find-mime-charset-1 ,begin ,end)))
+ `(and (featurep 'mule) mm-xemacs-find-mime-charset-1 ,begin ,end)))
(defun mm-find-mime-charset-region (b e &optional hack-charsets)
"Return the MIME charsets needed to encode the region between B and E.
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
1:16 a.m.
* Aidan Kehoe <kehoea(a)parhasard.net> writes:
This patch appears to be already in the sources. Must have come
across with my sync to upstream yesterday.
But...
Index: xemacs-packages/gnus/lisp/mm-util.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/gnus/lisp/mm-util.el,v
retrieving revision 1.5
diff -u -u -r1.5 mm-util.el
--- xemacs-packages/gnus/lisp/mm-util.el 2004/09/28 02:21:14 1.5
+++ xemacs-packages/gnus/lisp/mm-util.el 2005/02/27 16:18:47
＠＠ -304,7 +304,11 ＠＠
(cond ((string= lang "Japanese")
;; Japanese users may prefer iso-2022-jp to shift-jis.
'(iso-2022-jp iso-2022-jp-2 japanese-shift-jis
- iso-latin-1 utf-8)))))
+ iso-latin-1 utf-8))
+ ((find-coding-system 'utf-8)
+ '(iso-8859-1 iso-8859-2 iso-8859-15 utf-8))
+ (t
+ '(iso-8859-1 iso-8859-2 iso-8859-15 iso-2022-jp)))))
"Preferred coding systems for encoding outgoing messages.
...this hunk _isn't_. And it won't apply either.
Aidan, can you please take a look.
--
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
| I am Dyslexic of Borg. |
| Fusistance is retile. Your arse will be laminated. |
|------------------------------------<steve(a)sxemacs.org>---|
2:35 a.m.
New subject: [PATCH] mm-coding-system-priorities, (MIME charsets), revisited
Ar an ceathrú lá déag de mí Márta, scríobh Steve Youngs:
This patch appears to be already in the sources. Must have come
across with my sync to upstream yesterday.
But... [...] ...this hunk _isn't_. And it won't apply either.
Aidan, can you please take a look.
Here’s a patch, generated with Patcher, against the current source tree. I’m
slightly surprised patch(1) didn’t sniff it out from context.
xemacs-packages/gnus/ChangeLog addition:
2005-03-14 Aidan Kehoe <kehoea(a)parhasard.net>
* lisp/mm-util.el (mm-coding-system-priorities): Healthier default
with non-Japanese language environments.
XEmacs Packages source patch:
Diff command: cvs -q diff -u
Files affected: xemacs-packages/gnus/lisp/mm-util.el
Index: xemacs-packages/gnus/lisp/mm-util.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/gnus/lisp/mm-util.el,v
retrieving revision 1.6
diff -u -u -r1.6 mm-util.el
--- xemacs-packages/gnus/lisp/mm-util.el 2005/03/13 00:23:34 1.6
+++ xemacs-packages/gnus/lisp/mm-util.el 2005/03/14 01:26:51
＠＠ -334,7 +334,11 ＠＠
;; Japanese users prefer iso-2022-jp to euc-japan or
;; shift_jis, however iso-8859-1 should be used when
;; there are only ASCII text and Latin-1 characters.
- '(iso-8859-1 iso-2022-jp iso-2022-jp-2 shift_jis utf-8)))))
+ '(iso-8859-1 iso-2022-jp iso-2022-jp-2 shift_jis utf-8))
+ ((find-coding-system 'utf-8)
+ '(iso-8859-1 iso-8859-2 iso-8859-15 utf-8))
+ (t
+ '(iso-8859-1 iso-8859-2 iso-8859-15 iso-2022-jp)))))
"Preferred coding systems for encoding outgoing messages.
More than one suitable coding system may be found for some text.
--
“I, for instance, am gung-ho about open source because my family is being
held hostage in Rob Malda’s basement. But who fact-checks me, or Enderle,
when we say something in public? No-one!” -- Danny O’Brien
2:28 a.m.
New subject: [AC] Re: [PATCH] mm-coding-system-priorities, (MIME charsets), revisited
APPROVE COMMIT
* Aidan Kehoe <kehoea(a)parhasard.net> writes:
2005-03-14 Aidan Kehoe <kehoea(a)parhasard.net>
* lisp/mm-util.el (mm-coding-system-priorities): Healthier default
with non-Japanese language environments.
Norbert, ok, you can roll a new Gnus package now.
--
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
| I am Dyslexic of Borg. |
| Fusistance is retile. Your arse will be laminated. |
|------------------------------------<steve(a)sxemacs.org>---|
7169
days inactive
7190
days old
15 comments
3 participants
participants (3)
-
Adrian Aichner -
Aidan Kehoe -
Steve Youngs