Dear Developers, I've met function's value was not defined error several times when run `man something' in eshell mode. And finally got it fixed by change this two defination. Could you please help review and commit it to package repository? Thanks, FKtPp ChangeLog addition: 2009-06-12 It's me FKtPp ;) <m_pupil(a)yahoo.com.cn&gt; * em-cmpl.el (eshell-cmpl-man-function): Use #'manual-entry instead of #'man * em-unix.el (eshell/man): Use #'manual-entry instead of #'man eshell[Packages] source patch: Diff command: cvs -q diff -u Files affected: em-unix.el =================================================================== RCS em-cmpl.el =================================================================== RCS Index: em-cmpl.el =================================================================== RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/eshell/em-cmpl.el,v retrieving revision 1.2 diff -u -r1.2 em-cmpl.el --- em-cmpl.el 2008/08/27 21:26:30 1.2 +++ em-cmpl.el 2009/06/12 13:25:05 ＠＠ -168,7 +168,9 ＠＠ :type (get 'pcomplete-recexact 'custom-type) :group 'eshell-cmpl) -(defcustom eshell-cmpl-man-function 'man +(defcustom eshell-cmpl-man-function (if (featurep 'xemacs) + #'manual-entry + #'man) (documentation-property 'pcomplete-man-function 'variable-documentation) :type (get 'pcomplete-man-function 'custom-type) Index: em-unix.el =================================================================== RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/eshell/em-unix.el,v retrieving revision 1.3 diff -u -r1.3 em-unix.el --- em-unix.el 2008/08/27 21:26:32 1.3 +++ em-unix.el 2009/06/12 13:25:05 ＠＠ -163,7 +163,10 ＠＠ (defun eshell/man (&rest args) "Invoke man, flattening the arguments appropriately." - (funcall 'man (apply 'eshell-flatten-and-stringify args))) + (funcall (if (featurep 'xemacs) + #'manual-entry + #'man) + (apply 'eshell-flatten-and-stringify args))) (put 'eshell/man 'eshell-no-numeric-conversions t) _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches