Andreas Roehler writes:
Herewith a patch against latest XEmacs lisp.el.
We need a ChangeLog in the usual format. C-x 4 a is a good way to
format it, then cut and paste to the mail.
Some remarks on the patch:
diff -u lisp.el lisp.el
--- lisp.el 2008-11-29 17:00:18.000000000 +0100
+++ lisp.el 2008-11-29 17:00:18.000000000 +0100
[HUNK OMITTED]
@@ -175,13 +190,19 @@
This is identical to beginning-of-defun, except that point does not move
to the beginning of the line when `defun-prompt-regexp' is non-nil."
(interactive "p")
- (and arg (< arg 0) (not (eobp)) (forward-char 1))
- (and (re-search-backward (if defun-prompt-regexp
- (concat "^\\s(\\|"
- "\\(" defun-prompt-regexp "\\)\\s(")
- "^\\s(")
- nil 'move (or arg 1))
- (progn (goto-char (1- (match-end 0)))) t))
+ ;; (and arg (< arg 0) (not (eobp)) (forward-char 1))
Why is this commented out?
+ (unless arg (setq arg 1))
+ (cond
+ (beginning-of-defun-function
Our style for `cond' is to align the clauses to the right of cond:
(cond (beginning-of-defun-function (when (> arg 0)
(dotimes (i arg)
(funcall beginning-of-defun-function))))
(t (re-search-backward (if defun-prompt-regexp
(concat "^\\s(\\|"
"\\(" defun-prompt-regexp
"\\)\\s(")
"^\\s(")
nil 'move (or arg 1))
;; etc etc
)
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches