9:27 p.m.
It appears that the toolbar is being cleared and recreated for every
redraw. I have a patch that only clears the toolbars if the frame is
resized, which seems to be the original intent. I'm not sure if the
toolbar even needs to be cleared on the resize, but this patch saves a lot
of churn.
--
Jeff Sparkes
jsparkes(a)gmail.com
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
8:21 a.m.
Jeff Sparkes writes:
It appears that the toolbar is being cleared and recreated for every
redraw.
Great! I've been looking forward to a patch addressing unnecessary
redrawing for a long time!
It'll be a day or so before I can review, and I can't really address
Windows issues (see below for why that might matter).
I have a patch that only clears the toolbars if the frame is
resized, which seems to be the original intent. I'm not sure if
the toolbar even needs to be cleared on the resize, but this patch
saves a lot of churn.
Since toolbars can be placed on the right side and bottom, and even
top and left can have a button (typically Help) at the far end, it's
certainly true that some parts of all toolbars, and all of some
toolbars, *need* to be redrawn on resize.
Note to Windows users:
I suspect this was Windows-related, or at least done by a Windows
coder. There are many places where subwindows are dirtied explicitly,
which is way inefficient in Xt or GTK+ coding. At least from the
XEmacs code I've looked at, it doesn't seem like Windows has a proper
notion of "widget", so you need to redraw stuff "by hand" all the
time.
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
1:29 p.m.
On Fri, Jan 2, 2015 at 3:21 AM, Stephen J. Turnbull <stephen(a)xemacs.org>
wrote:
Jeff Sparkes writes:
> It appears that the toolbar is being cleared and recreated for every
> redraw.
Note to Windows users:
I suspect this was Windows-related, or at least done by a Windows
coder. There are many places where subwindows are dirtied explicitly,
which is way inefficient in Xt or GTK+ coding. At least from the
XEmacs code I've looked at, it doesn't seem like Windows has a proper
notion of "widget", so you need to redraw stuff "by hand" all the
time.
I have tested this with a cygwin build on windows (./configure --with-msw
--without-x) and found that the display behaviour didn't change. There
were some glitches in a right side toolbar when I resized, but they
happened with and without the patch.
--
Jeff Sparkes
jsparkes(a)gmail.com
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
9:42 a.m.
New subject: [A21.5] Re: Too many toolbar redraws
APPROVE 21.5
Jeff Sparkes writes:
I have tested this with a cygwin build on windows (./configure
--with-msw
--without-x) and found that the display behaviour didn't change. There
were some glitches in a right side toolbar when I resized, but they
happened with and without the patch.
OK, I've tested on two platforms (Mac "Yosemite" and Gentoo "a couple
months old") and it works fine for me, and certainly does reduce
"churn" on a X11 connection (even over a fast LAN, noticably so).
Please commit if you have the privileges, or I can do it if not.
Steve
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
10:30 a.m.
Ar an chéad lá de mí Eanair, scríobh Jeff Sparkes:
It appears that the toolbar is being cleared and recreated for every
redraw. I have a patch that only clears the toolbars if the frame is
resized, which seems to be the original intent. I'm not sure if the
toolbar even needs to be cleared on the resize, but this patch saves a lot
of churn.
You’re right that it shouldn’t be necessary for the toolbar to be created and
redrawn for every redisplay. This patch is a big improvement on the previous
situation, but it is incorrect, in that the various ENABLED-P elements in the
toolbar buttons are ignored. What we should do is pay attention to whether any
of the the toolbar buttons are dirty, and only then redraw.
--
‘Tramadol is further fed to cattle […] when working them […] (as draft
animals) so that the animals do not get tired quickly. …’
— Angewandte Chemie, Sept 2014, describing the social context of
(synthetic) tramadol having been found in Cameroon tree roots.
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
3537
days inactive
3595
days old
4 comments
3 participants
participants (3)
-
Aidan Kehoe -
Jeff Sparkes -
Stephen J. Turnbull