New subject: [A]: commit: Provide #'special-form-p, for the use of advice.el, perhaps other files.

Tuesday, 18 December 2007

        QUERY

On Dec 18, 2007 1:51 PM, Aidan Kehoe <aidan-guest(a)alioth.debian.org&gt; wrote:

...
 +DEFUN ("special-form-p", Fspecial_form_p, 1, 1, 0, /*
 +Return whether SUBR is a special form.  SUBR must be built-in.
 +*/
 +       (subr))
 +{
 +  subr = indirect_function (subr, 1);
 +  CHECK_SUBR (subr);
 +
 +  return XSUBR (subr)->max_args == UNEVALLED ? Qt : Qnil;
  }

I personally hate predicates that throw errors.  If I pass a string or an
integer to this function, I would like it to return nil.  Would you object
to changing that code to something like this?

{
  subr = indirect_function (subr, 0);
  return (SUBRP (subr) && XSUBR (subr)->max_args == UNEVALLED) ? Qt : Qnil;
}

-- 
Jerry James
http://loganjerry.googlepages.com/

_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

[Q]: commit: Provide #'special-form-p, for the use of advice.el, perhaps other files.