Ar an séiú lá de mí Méan Fómhair, scríobh Vin Shelton:
I think this patch broke the VS6 compile of fns.c:
C:\cygwin\usr\local\src\xemacs-21.5-proc-2010-09-06\src\fns.c(1198) :
warning C4244: '=' : conversion from 'double ' to 'long ',
possible
loss of data
C:\cygwin\usr\local\src\xemacs-21.5-proc-2010-09-06\src\fns.c(5866) :
error C2143: syntax error : missing ';' before 'type'
C:\cygwin\usr\local\src\xemacs-21.5-proc-2010-09-06\src\fns.c(5879) :
error C2065: 'obj' : undeclared identifier
NMAKE : fatal error U1077: 'cl' : return code '0x2'
Stop.
Thanks for looking into this.
What an odd error. Anyway, it’s clear enough what’s wrong once you look at
the relevant lines, and I’ve committed the below. Please confirm whether the
change fixes the build for you, as I mention in the ChangeLog entry I didn’t
see the problem with Visual Studio 2005, and thanks for reporting the
problem.
APPROVE COMMIT
NOTE: This patch has been committed.
# HG changeset patch
# User Aidan Kehoe <kehoea(a)parhasard.net>
# Date 1283875426 -3600
# Node ID 75bcb5bef4595fcc37f01e3e173d96b59fa8a821
# Parent 69f687b3ba9d833c9f7b2872e679b511df1c578b
Replace a doubled semi-colon with a single semi-colon, fns.c, for VS6's sake.
src/ChangeLog addition:
2010-09-07 Aidan Kehoe <kehoea(a)parhasard.net>
* fns.c (Freplace):
Replace an accidental double semi-colon with a single semi-colon,
hopefully fixing Vin's Visual Studio 6 build. (Visual Studio 2005
had no problem with it, oddly.)
diff -r 69f687b3ba9d -r 75bcb5bef459 src/ChangeLog
--- a/src/ChangeLog Mon Sep 06 17:29:51 2010 +0100
+++ b/src/ChangeLog Tue Sep 07 17:03:46 2010 +0100
@@ -1,3 +1,10 @@
+2010-09-07 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * fns.c (Freplace):
+ Replace an accidental double semi-colon with a single semi-colon,
+ hopefully fixing Vin's Visual Studio 6 build. (Visual Studio 2005
+ had no problem with it, oddly.)
+
2010-09-06 Aidan Kehoe <kehoea(a)parhasard.net>
Move #'replace to C; add bounds checking to it and to #'fill.
diff -r 69f687b3ba9d -r 75bcb5bef459 src/fns.c
--- a/src/fns.c Mon Sep 06 17:29:51 2010 +0100
+++ b/src/fns.c Tue Sep 07 17:03:46 2010 +0100
@@ -5862,7 +5862,7 @@
{
Ibyte *staging, *cursor;
Elemcount count, len1 = string_char_length (sequence1);
- Elemcount len2 = XINT (Flength (sequence2)), ii = 0;;
+ Elemcount len2 = XINT (Flength (sequence2)), ii = 0;
Lisp_Object obj;
check_sequence_range (sequence1, start1, end1, make_int (len1));
--
“Apart from the nine-banded armadillo, man is the only natural host of
Mycobacterium leprae, although it can be grown in the footpads of mice.”
-- Kumar & Clark, Clinical Medicine, summarising improbable leprosy research
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/mailman/listinfo/xemacs-patches