Ar an dara lá de mí na Samhain, scríobh Raymond Toy:
For the record make_time was changed from returning a list to a cons
in
changeset: 5948:417c790fd731
Reverting that one change makes gnus happy. Yay!
Ah, fair enough. Grand, I have reverted that, and that should settle things.
Thank you for some excellent bug reporting!
# HG changeset patch
# User Aidan Kehoe <kehoea(a)parhasard.net>
# Date 1509658684 0
# Thu Nov 02 21:38:04 2017 +0000
# Node ID 51ad3b1a1b9288836a9efba679cc7141495c9e35
# Parent efa8f1377817cf7f529bbd39b58857c7675c59ad
Have make_time() return a true list, not a cons, thank you Raymond Toy!
src/ChangeLog addition:
2017-11-02 Aidan Kehoe <kehoea(a)parhasard.net>
* editfns.c (make_time):
Revert part of 417c790fd731, have this function return a list,
never a cons. Thank you Raymond Toy!
tests/ChangeLog addition:
2017-11-02 Aidan Kehoe <kehoea(a)parhasard.net>
* automated/os-tests.el:
We've reverted to returning a list, not a cons, in
#'encode-time. Update tests to reflect this, thank you Raymond
Toy.
diff -r efa8f1377817 -r 51ad3b1a1b92 src/ChangeLog
--- a/src/ChangeLog Sun Oct 29 13:59:44 2017 +0000
+++ b/src/ChangeLog Thu Nov 02 21:38:04 2017 +0000
@@ -1,3 +1,9 @@
+2017-11-02 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * editfns.c (make_time):
+ Revert part of 417c790fd731, have this function return a list,
+ never a cons. Thank you Raymond Toy!
+
2017-10-28 Aidan Kehoe <kehoea(a)parhasard.net>
* file-coding.c (handle_possible_error_octet):
diff -r efa8f1377817 -r 51ad3b1a1b92 src/editfns.c
--- a/src/editfns.c Sun Oct 29 13:59:44 2017 +0000
+++ b/src/editfns.c Thu Nov 02 21:38:04 2017 +0000
@@ -1182,7 +1182,7 @@
Lisp_Object
make_time (time_t tiempo)
{
- return Fcons (make_fixnum (tiempo < 0 ? tiempo / 0x10000 : tiempo >> 16),
+ return list2 (make_fixnum (tiempo < 0 ? tiempo / 0x10000 : tiempo >> 16),
make_fixnum (tiempo & 0xFFFF));
}
diff -r efa8f1377817 -r 51ad3b1a1b92 tests/ChangeLog
--- a/tests/ChangeLog Sun Oct 29 13:59:44 2017 +0000
+++ b/tests/ChangeLog Thu Nov 02 21:38:04 2017 +0000
@@ -1,3 +1,10 @@
+2017-11-02 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * automated/os-tests.el:
+ We've reverted to returning a list, not a cons, in
+ #'encode-time. Update tests to reflect this, thank you Raymond
+ Toy.
+
2017-10-29 Aidan Kehoe <kehoea(a)parhasard.net>
* automated/lisp-tests.el:
diff -r efa8f1377817 -r 51ad3b1a1b92 tests/automated/os-tests.el
--- a/tests/automated/os-tests.el Sun Oct 29 13:59:44 2017 +0000
+++ b/tests/automated/os-tests.el Thu Nov 02 21:38:04 2017 +0000
@@ -127,9 +127,9 @@
(Check-Error args-out-of-range (encode-time 24 4 20 11 5 2017 -86401))
(Assert (equal (encode-time 24 4 20 11 5 2017 -86400)
- '(22806 . 5448))) ;; "05/12/17 09:04:25 PM"
+ '(22806 5448))) ;; "05/12/17 09:04:25 PM"
(Assert (equal (encode-time 24 4 20 11 5 2017 86400)
- '(22803 . 29256))) ;; "05/10/17 09:04:24 PM"
+ '(22803 29256))) ;; "05/10/17 09:04:24 PM"
(Check-Error args-out-of-range (encode-time 24 4 20 11 5 2017 86401))
;;; end of os-tests.el
--
‘As I sat looking up at the Guinness ad, I could never figure out /
How your man stayed up on the surfboard after forty pints of stout’
(C. Moore)