10:26 p.m.
NOTE: This patch has been committed.
Hi!
latin-euro-standards doesn't fit in the %-15s scheme pui currently
has. So, allow more characters.
Vin, would you accept a patch against 21.4? In this case I would
remove a byte-compiler warning as well (already done in 21.5.)?
norbert.
ChangeLog addition:
2005-02-19 Norbert Koch <viteno(a)xemacs.org>
* package-ui.el (pui-list-packages): The longest package name now
has 20 characters. Adapt the display.
21.5-lisp source patch:
Diff command: cvs -f -z3 -q diff -u -N
Files affected: package-ui.el
Index: package-ui.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/package-ui.el,v
retrieving revision 1.23
diff -u -r1.23 package-ui.el
--- package-ui.el 4 Nov 2004 23:05:55 -0000 1.23
+++ package-ui.el 19 Feb 2005 22:19:04 -0000
＠＠ -607,11 +607,11 ＠＠
"))
(if pui-list-verbose
- (insert " Latest Installed
- Package name Vers. Vers. Description
+ (insert " Latest Installed
+ Package name Vers. Vers. Description
")
- (insert " Latest
- Package name Vers. Description
+ (insert " Latest
+ Package name Vers. Description
"))
(insert sep-string)
(setq start (point))
＠＠ -640,13 +640,13 ＠＠
((numberp current-vers)
(setq current-vers (format "%.2f" current-vers))))
(insert
- (format "%s %-15s %-5.2f %-5s %s\n"
+ (format "%s %-20s %-5.2f %-5s %s\n"
(car disp) pkg-sym
(if (stringp version)
(string-to-number version)
version)
current-vers desc)))
- (insert (format "%s %-15s %-5s %s\n"
+ (insert (format "%s %-20s %-5s %s\n"
(car disp)
pkg-sym version desc)))
(save-excursion
10:41 p.m.
Norbert Koch <viteno(a)xemacs.org> writes:
NOTE: This patch has been committed.
Hi!
latin-euro-standards doesn't fit in the %-15s scheme pui currently
has. So, allow more characters.
Vin, would you accept a patch against 21.4? In this case I would
remove a byte-compiler warning as well (already done in 21.5.)?
Sure.
Are you changing the package file format in a way that's
backwards-incompatible, though?
- Vin
8:02 a.m.
Vin Shelton <acs(a)xemacs.org> writes:
Hello Vin,
Sure.
Thanks.
Are you changing the package file format in a way that's
backwards-incompatible, though?
No, I only give the package name more space to have an aligned view of
things.
Here's the patch along with a ChangeLog.
norbert.
2005-02-21 Norbert Koch <viteno(a)xemacs.org>
* package-ui.el (pui-list-packages): MF21.5, adapt to longer
package names, quell a byte-compiler warning, doc fix.
Index: package-ui.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/package-ui.el,v
retrieving revision 1.13.2.4
diff -u -u -r1.13.2.4 package-ui.el
--- package-ui.el 2004/06/22 01:49:47 1.13.2.4
+++ package-ui.el 2005/02/21 07:58:26
＠＠ -509,14 +509,15 ＠＠
(defun pui-display-maintainer (&optional no-error event)
"Display a package's maintainer in the minibuffer."
(interactive)
- (let (extent pkg-sym info maintainer)
+ (let (extent ;pkg-sym
+ info maintainer)
(save-excursion
(beginning-of-line)
(if (setq extent (extent-at (point) (current-buffer) 'pui))
(progn
- (setq pkg-sym (extent-property extent 'pui-package)
- info (extent-property extent 'pui-info)
- maintainer (package-get-info-prop info 'maintainer))
+ (setq ;pkg-sym (extent-property extent 'pui-package)
+ info (extent-property extent 'pui-info)
+ maintainer (package-get-info-prop info 'maintainer))
(message (format "Maintainer: %s" maintainer)))
(if no-error
(clear-message nil)
＠＠ -564,7 +565,7 ＠＠
`\\[pui-toggle-package-delete-key]' to select/unselect the current package for
removal.
`\\[pui-add-required-packages]' to add any packages required by those selected.
`\\[pui-install-selected-packages]' to install/delete selected packages.
- `\\[pui-display-info]' to display additional information about the package in the
modeline.
+ `\\[pui-display-info]' to display additional information about the package in the
minibuffer.
`\\[pui-display-maintainer]' to display the package's maintainer in the
minibuffer
`\\[pui-list-packages]' to refresh the package list.
`\\[pui-toggle-verbosity-redisplay]' to toggle between a verbose and non-verbose
display.
＠＠ -606,11 +607,11 ＠＠
"))
(if pui-list-verbose
- (insert " Latest Installed
- Package name Vers. Vers. Description
+ (insert " Latest Installed
+ Package name Vers. Vers. Description
")
- (insert " Latest
- Package name Vers. Description
+ (insert " Latest
+ Package name Vers. Description
"))
(insert sep-string)
(setq start (point))
＠＠ -639,13 +640,13 ＠＠
((numberp current-vers)
(setq current-vers (format "%.2f" current-vers))))
(insert
- (format "%s %-15s %-5.2f %-5s %s\n"
+ (format "%s %-20s %-5.2f %-5s %s\n"
(car disp) pkg-sym
(if (stringp version)
(string-to-number version)
version)
current-vers desc)))
- (insert (format "%s %-15s %-5s %s\n"
+ (insert (format "%s %-20s %-5s %s\n"
(car disp)
pkg-sym version desc)))
(save-excursion
1:56 a.m.
New subject: [AC21.4] Pui, adapt package name length in display
Norbert Koch <viteno(a)xemacs.org> writes:
Vin Shelton <acs(a)xemacs.org> writes:
Hello Vin,
> Sure.
Thanks.
> Are you changing the package file format in a way that's
> backwards-incompatible, though?
No, I only give the package name more space to have an aligned view of
things.
Here's the patch along with a ChangeLog.
norbert.
2005-02-21 Norbert Koch <viteno(a)xemacs.org>
* package-ui.el (pui-list-packages): MF21.5, adapt to longer
package names, quell a byte-compiler warning, doc fix.
APPROVE COMMIT 21.4
Thanks for the patch, Norbert. It will appear in XEmacs 21.4.18,
"Constant Variable".
- Vin
7002
days inactive
7006
days old
3 comments
2 participants
participants (2)
-
Norbert Koch -
Vin Shelton