APPROVE COMMIT 21.5 Vin, Do you want this one for 21.4? Henry S. Thompson writes: I've taken the liberty of greatly extending the comment, and prepared the attached patch. diff -r c6d4ffc018a6 src/ChangeLog --- a/src/ChangeLog Sat Jan 31 17:43:20 2009 +0000 +++ b/src/ChangeLog Mon Feb 02 22:53:07 2009 +0900 ＠＠ -1,3 +1,9 ＠＠ +2009-02-02 Stephen J. Turnbull <stephen(a)xemacs.org&gt; + + * frame-x.c (x_init_frame_2): Placate openbox by calling + update_frame_icon. Suggested by Henry S. Thompson + <ht(a)inf.ed.ac.uk&gt; in <f5btz7ghm5k(a)hildegard.inf.ed.ac.uk&gt;. + 2009-01-31 Aidan Kehoe <kehoea(a)parhasard.net&gt; * unicode.c (unicode_convert): diff -r c6d4ffc018a6 src/frame-x.c --- a/src/frame-x.c Sat Jan 31 17:43:20 2009 +0000 +++ b/src/frame-x.c Mon Feb 02 22:53:07 2009 +0900 ＠＠ -2160,6 +2160,14 ＠＠ * We'll just need to be careful in the modeline specs. */ update_frame_title (f); + /* Henry S. Thompson: + * Must set icon resource before mapping frame, or some WMs may + * lose the icon (openbox). See <f5bhc3efb17(a)hildegard.inf.ed.ac.uk&gt;. + * SJT: + * This probably means that the frame-icon library won't work with + * that WM. + */ + update_frame_icon (f); } static void _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches