Thanks for the information. Yes, I think Aidan's patch is more
complete and should be used.
Thank you for telling me how to send patches and ChangeLogs. I learned
something this time.
Stephen J. Turnbull writes:
Vin: Aidan's patch supersedes for 21.4.
Thank you for your contribution. It would have been accepted, but as
it turns out, Aidan Kehoe beat you to the punch with a somewhat more
complete patch, so I'm going to ask him to apply his, and yours is not
needed. I apologize for asking you to do this work unnecessarily.
I hope you will continue to contribute in the future, in any form
convenient to you. With regard to the patch you submitted, it would
have been useful, but there are several improvements that could be
made to make it easier for us to apply.
1. Use a context diff (diff -u is preferred, diff -c is acceptable).
Context diffs often can be applied if the file has changed since
the version you are using, while ordinary diffs normally will be
rejected by patch.
2. Your ChangeLog should use all TABs for leading indentation.
I attach Aidan's patch for your reference. It satisfies both those
conditions, and is generally done in excellent style.
Baoqiu Cui <cbaoqiu at yahoo.com>