7:14 p.m.
Ar an t-ochtú lá is fiche de mí na Samhain, scríobh Dr. Volker Zell:
Aidan, can we install this patch for 21.4 and 21.5 ? It seems to do
the
right thing.
It’s Vin’s call as to whether it goes into 21.4, but I see no reason for it
not to.
APPROVE COMMIT 21.5, RECOMMEND 21.4.
NOTE: This patch has been committed.
src/ChangeLog addition:
2006-11-29 Aidan Kehoe <kehoea(a)parhasard.net>
* sound.c (init_native_sound):
Only X11 and GTK devices can possibly not be on the console of the
associated machine. Fixes a crash when init_native_sound is called
on a msprinter device.
XEmacs Trunk source patch:
Diff command: cvs -q diff -Nu
Files affected: src/sound.c
===================================================================
RCS
Index: src/sound.c
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/sound.c,v
retrieving revision 1.27
diff -u -u -r1.27 sound.c
--- src/sound.c 2006/07/11 23:40:17 1.27
+++ src/sound.c 2006/11/29 19:06:06
＠＠ -590,7 +590,7 ＠＠
static void
init_native_sound (struct device *d)
{
- if (DEVICE_TTY_P (d) || DEVICE_STREAM_P (d) || DEVICE_MSWINDOWS_P(d))
+ if (!(DEVICE_X_P(d) || DEVICE_GTK_P(dev)))
DEVICE_ON_CONSOLE_P (d) = 1;
#ifdef HAVE_X_WINDOWS
else
--
Santa Maradona, priez pour moi!
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
4:58 a.m.
New subject: [Q21.4] Avoid a crash in Cygwin when clicking File -> Print under Win32
QUERY
On 11/29/06, Aidan Kehoe <kehoea(a)parhasard.net> wrote:
Ar an t-ochtú lá is fiche de mí na Samhain, scríobh Dr. Volker Zell:
> Aidan, can we install this patch for 21.4 and 21.5 ? It seems to do the
> right thing.
It's Vin's call as to whether it goes into 21.4, but I see no reason for it
not to.
APPROVE COMMIT 21.5, RECOMMEND 21.4.
NOTE: This patch has been committed.
src/ChangeLog addition:
2006-11-29 Aidan Kehoe <kehoea(a)parhasard.net>
* sound.c (init_native_sound):
Only X11 and GTK devices can possibly not be on the console of the
associated machine. Fixes a crash when init_native_sound is called
on a msprinter device.
XEmacs Trunk source patch:
Diff command: cvs -q diff -Nu
Files affected: src/sound.c
===================================================================
RCS
Index: src/sound.c
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/sound.c,v
retrieving revision 1.27
diff -u -u -r1.27 sound.c
--- src/sound.c 2006/07/11 23:40:17 1.27
+++ src/sound.c 2006/11/29 19:06:06
＠＠ -590,7 +590,7 ＠＠
static void
init_native_sound (struct device *d)
{
- if (DEVICE_TTY_P (d) || DEVICE_STREAM_P (d) || DEVICE_MSWINDOWS_P(d))
+ if (!(DEVICE_X_P(d) || DEVICE_GTK_P(dev)))
I don't know much about this part of the code (or anything about gtk),
but what is dev? If I got the regexp syntax correct, this is the only
occurance in the source file.
- Vin
--
The Journey by Mary Oliver
http://www.poemhunter.com/p/m/poem.asp?poet=6771&poem=30506
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
10:42 a.m.
New subject: [Q21.4] Avoid a crash in Cygwin when clicking File -> Print under Win32
Ar an t-ochtú lá de mí na Nollaig, scríobh Vin Shelton:
QUERY
>
> [...] It's Vin's call as to whether it goes into 21.4, but I see no
> reason for it not to. [...]
>
> static void
> init_native_sound (struct device *d)
> {
> - if (DEVICE_TTY_P (d) || DEVICE_STREAM_P (d) || DEVICE_MSWINDOWS_P(d))
> + if (!(DEVICE_X_P(d) || DEVICE_GTK_P(dev)))
I don't know much about this part of the code (or anything about gtk),
but what is dev? If I got the regexp syntax correct, this is the only
occurance in the source file.
Hah, that is indeed a reason for it not to go in. (dev) should have been
(d), and as it is that code won’t compile with GTK.
--
Santa Maradona, priez pour moi!
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
6:38 p.m.
New subject: [AC21.4] Avoid a crash in Cygwin when clicking File -> Print under Win32
APPROVE COMMIT 21.4
Made the obvious fix. Thanks for the patch, Aidan.
I will commit a fix for 21.5.
- Vin
On 12/9/06, Aidan Kehoe <kehoea(a)parhasard.net> wrote:
Ar an t-ochtú lá de mí na Nollaig, scríobh Vin Shelton:
> QUERY
>
> >
> > [...] It's Vin's call as to whether it goes into 21.4, but I see no
> > reason for it not to. [...]
> >
> > static void
> > init_native_sound (struct device *d)
> > {
> > - if (DEVICE_TTY_P (d) || DEVICE_STREAM_P (d) || DEVICE_MSWINDOWS_P(d))
> > + if (!(DEVICE_X_P(d) || DEVICE_GTK_P(dev)))
>
> I don't know much about this part of the code (or anything about gtk),
> but what is dev? If I got the regexp syntax correct, this is the only
> occurance in the source file.
Hah, that is indeed a reason for it not to go in. (dev) should have been
(d), and as it is that code won't compile with GTK.
--
Santa Maradona, priez pour moi!
--
The Journey by Mary Oliver
http://www.poemhunter.com/p/m/poem.asp?poet=6771&poem=30506
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches
6587
days inactive
6597
days old
3 comments
2 participants
participants (2)
-
Aidan Kehoe -
Vin Shelton