APPROVE COMMIT 21.5
Both GCC 4.0.3 and 4.1.1 issue warnings on this code due to a missing
sentinel. The sentinel (the terminating NULL argument) is not really
missing, of course, it has just been cast to an XtArgVal. This patch
removes the casts (which are unnecessary anyway with an ANSI C compiler,
which we require) so that GCC will stop moaning.
src/ChangeLog addition:
2006-06-19 Jerry James <james(a)xemacs.org>
* frame-x.c (x_set_frame_properties): Remove casts to silence GCC
warnings about a missing sentinel.
xemacs-21.5 source patch:
Diff command: cvs -q diff -uN
Files affected: src/frame-x.c
Index: src/frame-x.c
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/frame-x.c,v
retrieving revision 1.74
diff -d -u -r1.74 frame-x.c
--- src/frame-x.c 2006/05/22 22:07:07 1.74
+++ src/frame-x.c 2006/06/19 18:43:44
@@ -783,12 +783,12 @@
/* !!#### Verify this + 1 and document
as zero-termination */
XtRString, extval, extvallen + 1,
- (XtArgVal) NULL);
+ NULL);
}
else
XtVaSetValues (w, XtVaTypedArg, extprop, XtRInt,
XINT (val), sizeof (int),
- (XtArgVal) NULL);
+ NULL);
}
else if (SYMBOLP (prop))
{
@@ -887,7 +887,7 @@
/* !!#### Verify this + 1 and document
as zero-termination */
XtRString, extval, extvallen + 1,
- (XtArgVal) NULL);
+ NULL);
}
#ifdef HAVE_SCROLLBARS
--
Jerry James, Assistant Professor james(a)xemacs.org
Computer Science Department
http://www.cs.usu.edu/~jerry/
Utah State University