Happy New Year to you, Didier!
Ar an dara lá de mí Eanair, scríobh Didier Verna:
Hello there, happy new year to every one !
Aidan Kehoe wrote:
> APPROVE COMMIT
>
> NOTE: This patch has been committed.
>
> # HG changeset patch
> # User Aidan Kehoe <kehoea(a)parhasard.net>
> # Date 1325261131 0
> # Node ID bd80d9103fc8d867b63865e0979c61a9bb3926fd
> # Parent 5e256f495401fa242ea0e8d330807ecaae2b709f
> Integrate CL code better into core, remove obsolete compatibility code.
Aidan, you cannot just remove obsolete compatibility code like that.
You're breaking several packages from our repository (Gnus, w3 and
others) that still use the cl-* functions (cl-put/map/gethash notably)
and who knows how many others that we're not aware of.
I did a grep and a build (looking for “not known to be found” messages) when
removing the aliases, and really very few places do use them; w3, as you
mentioned, browse-cltl2.el, and sb-w3.el, which takes code from w3. Gnus
doesn’t use them if #'gethash is available. Upstream w3 doesn’t use them.
I think you need to at least defalias the cl-* functions to the
built-in
ones.
I think this is a reasonable way to prompt the users of the cl-* functions
to change their code to use function names that have been available in
XEmacs since 1997 and GNU Emacs since 1999.
I’ll update browse-cltl2.el and sb-w3.el in the next few days, and I’ll see
is it reasonable to merge in upstream changes into w3 too; if not, I’ll
change only the function names.
Best,
Aidan
--
‘Iodine deficiency was endemic in parts of the UK until, through what has been
described as “an unplanned and accidental public health triumph”, iodine was
added to cattle feed to improve milk production in the 1930s.’
(EN Pearce, Lancet, June 2011)
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches