1 new commit in XEmacs: https://bitbucket.org/xemacs/xemacs/changeset/2dbefd79b3d3/ changeset: 2dbefd79b3d3 user: stephen_at_xemacs date: 2011-10-28 18:10:32 summary: Prevent SIGPIPEs in deactivate_process(). * process.c (deactivate_process): Use Lstream_close_noflush on output pipe instead of Lstream_close. * lstream.c (Lstream_close_noflush): New. Factored out of Lstream_close. (Lstream_close): Use Lstream_close_noflush. * lstream.h (Lstream_close_noflush): Declare it. affected #: 4 files diff -r 3fde0e346ad710f69d233e5bc8d47defef4ea53f -r 2dbefd79b3d3713ac08021ff1a8ce6efd034d607 src/ChangeLog --- a/src/ChangeLog +++ b/src/ChangeLog ＠＠ -1,3 +1,16 ＠＠ +2011-10-29 Stephen J. Turnbull <stephen(a)xemacs.org&gt; + + Prevent SIGPIPEs in deactivate_process(). + + * process.c (deactivate_process): + Use Lstream_close_noflush on output pipe instead of Lstream_close. + + * lstream.c (Lstream_close_noflush): + New. Factored out of Lstream_close. + (Lstream_close): Use Lstream_close_noflush. + + * lstream.h (Lstream_close_noflush): Declare it. + 2011-10-29 Stephen J. Turnbull <stephen(a)xemacs.org&gt; Prevent assert at frame.c, l. 6311 by initializing glyph cachels. diff -r 3fde0e346ad710f69d233e5bc8d47defef4ea53f -r 2dbefd79b3d3713ac08021ff1a8ce6efd034d607 src/lstream.c --- a/src/lstream.c +++ b/src/lstream.c ＠＠ -791,6 +791,45 ＠＠ return Lstream_flush (lstr); } +/* Close the stream without flushing buffers. + In current practice, this is only useful when a subprocess terminates + unexpectedly, and the OS closes its pipes without warning. In that case, + we do not want to flush our output buffers, as there is no longer a pipe + to write to. + This nomenclature may deserve review if XEmacs starts getting called as + a subprocess. */ + +int +Lstream_close_noflush (Lstream *lstr) +{ + lstr->flags &= ~LSTREAM_FL_IS_OPEN; + lstr->byte_count = 0; + /* Note that Lstream_flush() reset all the buffer indices. That way, + the next call to Lstream_putc(), Lstream_getc(), or Lstream_ungetc() + on a closed stream will call into the function equivalents, which will + cause an error. */ + + /* We set the pointers to 0 so that we don't lose when this function + is called more than once on the same object */ + if (lstr->out_buffer) + { + xfree (lstr->out_buffer); + lstr->out_buffer = 0; + } + if (lstr->in_buffer) + { + xfree (lstr->in_buffer); + lstr->in_buffer = 0; + } + if (lstr->unget_buffer) + { + xfree (lstr->unget_buffer); + lstr->unget_buffer = 0; + } + + return 0; +} + /* Close the stream. All data will be flushed out. If the stream is already closed, nothing happens. Note that, even if all data has already been flushed out, the act of closing a stream may generate more ＠＠ -838,30 +877,7 ＠＠ rc = -1; } - lstr->flags &= ~LSTREAM_FL_IS_OPEN; - lstr->byte_count = 0; - /* Note that Lstream_flush() reset all the buffer indices. That way, - the next call to Lstream_putc(), Lstream_getc(), or Lstream_ungetc() - on a closed stream will call into the function equivalents, which will - cause an error. */ - - /* We set the pointers to 0 so that we don't lose when this function - is called more than once on the same object */ - if (lstr->out_buffer) - { - xfree (lstr->out_buffer); - lstr->out_buffer = 0; - } - if (lstr->in_buffer) - { - xfree (lstr->in_buffer); - lstr->in_buffer = 0; - } - if (lstr->unget_buffer) - { - xfree (lstr->unget_buffer); - lstr->unget_buffer = 0; - } + Lstream_close_noflush (lstr); return rc; } diff -r 3fde0e346ad710f69d233e5bc8d47defef4ea53f -r 2dbefd79b3d3713ac08021ff1a8ce6efd034d607 src/lstream.h --- a/src/lstream.h +++ b/src/lstream.h ＠＠ -306,6 +306,7 ＠＠ int Lstream_rewind (Lstream *lstr); int Lstream_seekable_p (Lstream *lstr); int Lstream_close (Lstream *lstr); +int Lstream_close_noflush (Lstream *lstr); void Lstream_delete (Lstream *lstr); void Lstream_set_character_mode (Lstream *str); diff -r 3fde0e346ad710f69d233e5bc8d47defef4ea53f -r 2dbefd79b3d3713ac08021ff1a8ce6efd034d607 src/process.c --- a/src/process.c +++ b/src/process.c ＠＠ -2150,8 +2150,20 ＠＠ /* Must call this before setting the streams to nil */ event_stream_unselect_process (p, 1, 1); + /* We can get here in case of a crash in the external process, and then + the Lstream_close on output will cause a SIGPIPE, which we're not ready + for here. It looks to me like all cases where this function is called + we know the process has exited (but I'm not 100% sure for the call in + execute_internal_event (event-stream.c)), so it should be OK to use + Lstream_close_noflush. + + #### The layering here needs a rethink. We should just be able + to call Lstream_close, and let the Lstream's implementation decide + if it can flush safely or not. The immediate problem is that the + Lstream needs to know the process's status, but I don't think it has + a handle to the process. */ if (!NILP (DATA_OUTSTREAM (p))) - Lstream_close (XLSTREAM (DATA_OUTSTREAM (p))); + Lstream_close_noflush (XLSTREAM (DATA_OUTSTREAM (p))); if (!NILP (DATA_INSTREAM (p))) Lstream_close (XLSTREAM (DATA_INSTREAM (p))); if (!NILP (DATA_ERRSTREAM (p))) Repository URL: https://bitbucket.org/xemacs/xemacs/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email. _______________________________________________ XEmacs-Patches mailing list XEmacs-Patches(a)xemacs.org http://lists.xemacs.org/mailman/listinfo/xemacs-patches