Yes, I see. I think you should augment the ChangeLog with your explanation.

(I was led astray by the reference to Sebastian Freundt's mail, thinking that was a link to an email archive which would describe the problem in more detail.) Thanks! Vin On 8/8/07, Aidan Kehoe <kehoea(a)parhasard.net&gt; wrote: > > Ar an t-ochtú lá de mí Lúnasa, scríobh Vin Shelton: > > > QUERY > > > > What bug does this fix? > > M-: (this-is-not-a-function nil t) RET > > would signal > > Invalid function: #<INTERNAL OBJECT (XEmacs bug?) (symbol-value-forward type 13) 0x5e3740> > > instead of > > Symbol's function definition is void: this-is-not-a-function > > > Is this patch needed for 21.4? > > No; the bug it fixes only happens in 21.5. > > > On 8/8/07, Aidan Kehoe <kehoea(a)parhasard.net&gt; wrote: > > > > > > APPROVE COMMIT > > > > > > NOTE: This patch has been committed. > > > > > > src/ChangeLog addition: > > > > > > 2007-08-08 Aidan Kehoe <kehoea(a)parhasard.net&gt; > > > > > > * eval.c (Feval): fix, stick with original error messages instead > > > of referring to the indirected function. > > > From Sebastian Freundt's mail > > > nhtfy9sitjf.fsf(a)muck.math.tu-berlin.de . > > > > > > > > > XEmacs Trunk source patch: > > > Diff command: cvs -q diff -u > > > Files affected: src/eval.c > > > =================================================================== > > > RCS > > > > > > Index: src/eval.c > > > =================================================================== > > > RCS file: /pack/xemacscvs/XEmacs/xemacs/src/eval.c,v > > > retrieving revision 1.97 > > > diff -u -r1.97 eval.c > > > --- src/eval.c 2007/06/22 00:21:17 1.97 > > > +++ src/eval.c 2007/08/08 14:40:53 > > > ＠＠ -3799,7 +3799,12 ＠＠ > > > goto invalid_function; > > > } > > > } > > > - else /* ! (SUBRP (fun) || COMPILED_FUNCTIONP (fun) || CONSP (fun)) */ > > > + else if (UNBOUNDP (fun)) > > > + { > > > + val = signal_void_function_error (original_fun); > > > + } > > > + else /* ! (SUBRP (fun) || COMPILED_FUNCTIONP (fun) || CONSP (fun) > > > + UNBOUNDP (fun)) */ > > > { > > > invalid_function: > > > val = signal_invalid_function_error (fun); > > > > > > -- > > > On the quay of the little Black Sea port, where the rescued pair came once > > > more into contact with civilization, Dobrinton was bitten by a dog which was > > > assumed to be mad, though it may only have been indiscriminating. (Saki) > > > > > > _______________________________________________ > > > XEmacs-Patches mailing list > > > XEmacs-Patches(a)xemacs.org > > > http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches > > > > > > > > > -- > > The Journey by Mary Oliver > > http://www.poemhunter.com/p/m/poem.asp?poet=6771&poem=30506 > > -- > On the quay of the little Black Sea port, where the rescued pair came once > more into contact with civilization, Dobrinton was bitten by a dog which was > assumed to be mad, though it may only have been indiscriminating. (Saki) > > _______________________________________________ > XEmacs-Patches mailing list > XEmacs-Patches(a)xemacs.org > http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches > -- The Journey by Mary Oliver http://www.poemhunter.com/p/m/poem.asp?poet=6771&poem=30506