7:23 p.m.
It's been bugging me to no end that "make beta" would delete my
packages symlinks. If there's no objection, I'll commit this on the
weekend.
2005-12-29 Mike Sperber <mike(a)xemacs.org>
* Makefile.in.in (top-distclean-noconfig): Don't delete
site-packages xemacs-packages mule-packages site-lisp---those are
supposed to stick around.
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
Index: Makefile.in.in
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/Makefile.in.in,v
retrieving revision 1.29
diff -u -r1.29 Makefile.in.in
--- Makefile.in.in 22 Nov 2005 07:14:48 -0000 1.29
+++ Makefile.in.in 29 Dec 2005 19:21:37 -0000
＠＠ -564,7 +564,6 ＠＠
## Like `distclean' but don't delete files created by `configure'.
top-distclean-noconfig: FRC.distclean-noconfig
-$(RM) TAGS .sbinit lock/* lisp/finder-inf.el*
- -$(RM) -r site-packages xemacs-packages mule-packages site-lisp
distclean-noconfig: top-mostlyclean top-clean top-distclean-noconfig
for d in $(SUBDIR); do (cd ./$$d && $(MAKE) $(RECURSIVE_MAKE_ARGS) $＠); done
3:29 a.m.
QUERY
ms> It's been bugging me to no end that "make beta" would delete
ms> my packages symlinks. If there's no objection, I'll commit
ms> this on the weekend.
ms> 2005-12-29 Mike Sperber <mike(a)xemacs.org>
* Makefile.in.in (top-distclean-noconfig): Don't delete
site-packages xemacs-packages mule-packages site-lisp---those are
supposed to stick around.
I agree that "make beta" should not remove those links. However, I
think this is the wrong place to make this change. *Your* package
symlinks are not part of the *distribution*; distclean should remove
them.
Didn't Ben create a special "betaclean" target recently?
--
School of Systems and Information Engineering http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.
6:58 a.m.
Thanks for reviewing!
"Stephen J. Turnbull" <stephen(a)xemacs.org> writes:
I agree that "make beta" should not remove those links.
However, I
think this is the wrong place to make this change. *Your* package
symlinks are not part of the *distribution*; distclean should remove
them.
Well, all kinds of other files I might have put there myself, "make
distclean" won't delete---it's supposed to delete the files created as
part of some (pre-)build process. I don't think the ...-packages file
could have been created by any way other than manually.
Didn't Ben create a special "betaclean" target
recently?
If he did, it's not checked in.
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
8:18 a.m.
New subject: [A21.5] Don't delete ...-packages on various ...-clean targets
APPROVE 21.5
>>>> "ms" == Michael Sperber
<sperber(a)informatik.uni-tuebingen.de> writes:
ms> Well, all kinds of other files I might have put there myself,
ms> "make distclean" won't delete---it's supposed to delete the
ms> files created as part of some (pre-)build process. I don't
ms> think the ...-packages file could have been created by any way
ms> other than manually.
OK, sounds reasonable. This particular behavior is present in
21.1.14, so it probably goes all the way back to 20.5. I suspect
Steve Baur or somebody had code in there to copy an old tree into
package format.
A quick grep shows no code that does anything but read (or remove ;-)
those directory entries, so I accept your rationale.
--
School of Systems and Information Engineering http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.
12:42 p.m.
New subject: [C21.5] Don't delete ...-packages on various ...-clean targets
COMMIT 21.5
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
6689
days inactive
6691
days old
4 comments
2 participants
participants (2)
-
Michael Sperber -
Stephen J. Turnbull