5:43 p.m.
I spent too much time hunting this down myself, I think it’s worth sparing
other people that.
APPROVE COMMIT
NOTE: This patch has been committed.
src/ChangeLog addition:
2006-08-06 Aidan Kehoe <kehoea(a)parhasard.net>
* doc.c (Fsnarf_documentation):
Add an assertion and a comment, rather than crashing in the
76584th call of hash_string when someone's using a DOC file that
doesn't match the format.
XEmacs Trunk source patch:
Diff command: cvs -q diff -Nu
Files affected: src/doc.c
Index: src/doc.c
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/doc.c,v
retrieving revision 1.38
diff -u -u -r1.38 doc.c
--- src/doc.c 2006/05/21 18:35:31 1.38
+++ src/doc.c 2006/08/06 16:34:28
＠＠ -742,6 +742,10 ＠＠
if (p != end)
{
end = qxestrchr (p, '\n');
+ /* If you trigger a failure with of this assertion, you probably
+ configured with --quick-build and need to to rebuild your DOC
+ file. */
+ assert((end - p - 2) > -1);
sym = oblookup (Vobarray, p + 2, end - p - 2);
if (SYMBOLP (sym))
{
--
Santa Maradona, priez pour moi!
4:37 p.m.
New subject: [Q] Add an informative assertion to snarf-documentation
QUERY
Aidan Kehoe <kehoea(a)parhasard.net> wrote:
Index: src/doc.c
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/doc.c,v
retrieving revision 1.38
diff -u -u -r1.38 doc.c
--- src/doc.c 2006/05/21 18:35:31 1.38
+++ src/doc.c 2006/08/06 16:34:28
＠＠ -742,6 +742,10 ＠＠
if (p != end)
{
end = qxestrchr (p, '\n');
+ /* If you trigger a failure with of this assertion, you probably
+ configured with --quick-build and need to to rebuild your DOC
+ file. */
+ assert((end - p - 2) > -1);
sym = oblookup (Vobarray, p + 2, end - p - 2);
if (SYMBOLP (sym))
{
There is a typo in the first line of your comment. You don't need both
"with" and "of" before "this assertion".
Regards,
--
Jerry James, Assistant Professor james(a)xemacs.org
Computer Science Department http://www.cs.usu.edu/~jerry/
Utah State University
7:40 p.m.
New subject: [Q] Add an informative assertion to snarf-documentation
Nor do you need "to to".
- Vin
On 8/7/06, Jerry James <james(a)xemacs.org> wrote:
QUERY
Aidan Kehoe <kehoea(a)parhasard.net> wrote:
> Index: src/doc.c
> ===================================================================
> RCS file: /pack/xemacscvs/XEmacs/xemacs/src/doc.c,v
> retrieving revision 1.38
> diff -u -u -r1.38 doc.c
> --- src/doc.c 2006/05/21 18:35:31 1.38
> +++ src/doc.c 2006/08/06 16:34:28
> ＠＠ -742,6 +742,10 ＠＠
> if (p != end)
> {
> end = qxestrchr (p, '\n');
> + /* If you trigger a failure with of this assertion, you probably
> + configured with --quick-build and need to to rebuild your DOC
> + file. */
> + assert((end - p - 2) > -1);
> sym = oblookup (Vobarray, p + 2, end - p - 2);
> if (SYMBOLP (sym))
> {
There is a typo in the first line of your comment. You don't need both
"with" and "of" before "this assertion".
Regards,
--
Jerry James, Assistant Professor james(a)xemacs.org
Computer Science Department http://www.cs.usu.edu/~jerry/
Utah State University
--
Whoever you are, no matter how lonely,
the world offers itself to your imagination,
calls to you like the wild geese, harsh and exciting--
over and over announcing your place
in the family of things. Mary Oliver
9:40 p.m.
New subject: [Q] Add an informative assertion to snarf-documentation
Ar an seachtú lá de mí Lúnasa, scríobh Vin Shelton:
Nor do you need "to to".
On 8/7/06, Jerry James <james(a)xemacs.org> wrote:
> [...]
>
> There is a typo in the first line of your comment. You don't need both
> "with" and "of" before "this assertion".
Thank you both. I’ve committed a correction to this, as well as to a few
other indications that I need to spend more time writing languages that
don’t have defined compilers. No ChangeLog entries; if that offends anyone’s
sensibilities, please shout.
--
Santa Maradona, priez pour moi!
6711
days inactive
6712
days old
3 comments
3 participants
participants (3)
-
Aidan Kehoe -
Jerry James -
Vin Shelton