APPROVE COMMIT NOTE: This patch has been committed # HG changeset patch # User Aidan Kehoe <kehoea(a)parhasard.net&gt; # Date 1523133647 -3600 # Sat Apr 07 21:40:47 2018 +0100 # Node ID f45199815d5daab32f0943a69987fdd686593289 # Parent 3e52d0a8ca3db32b980c27ee9d8bbc4b979af68b Handle bignum START, END values as appropriate, #'insert-file-contents-internal src/ChangeLog addition: 2018-04-07 Aidan Kehoe <kehoea(a)parhasard.net&gt; * fileio.c (Fsubstitute_in_file_name): Fixup some whitespace here. * fileio.c (Finsert_file_contents_internal): Handle bignum values for START, END. Error if the difference between START and END means the relevant buffer would become too big to handle. * insdel.c (buffer_insert_string_1): Check the new buffer size in terms of characters, not bytes. * lstream.c (make_filedesc_stream_1): * lstream.c (make_filedesc_input_stream): * lstream.c (make_filedesc_output_stream): * lstream.h: Use the OFF_T type for the OFFSET argument to these functions, Bytecount for the COUNT argument, as has long been the most reasonable approach. diff -r 3e52d0a8ca3d -r f45199815d5d src/ChangeLog --- a/src/ChangeLog Fri Apr 06 14:14:46 2018 +0100 +++ b/src/ChangeLog Sat Apr 07 21:40:47 2018 +0100 ＠＠ -1,3 +1,20 ＠＠ +2018-04-07 Aidan Kehoe <kehoea(a)parhasard.net&gt; + + * fileio.c (Fsubstitute_in_file_name): Fixup some whitespace here. + * fileio.c (Finsert_file_contents_internal): + Handle bignum values for START, END. Error if the difference + between START and END means the relevant buffer would become too + big to handle. + * insdel.c (buffer_insert_string_1): + Check the new buffer size in terms of characters, not bytes. + * lstream.c (make_filedesc_stream_1): + * lstream.c (make_filedesc_input_stream): + * lstream.c (make_filedesc_output_stream): + * lstream.h: + Use the OFF_T type for the OFFSET argument to these functions, + Bytecount for the COUNT argument, as has long been the most + reasonable approach. + 2018-04-06 Aidan Kehoe <kehoea(a)parhasard.net&gt; * process-unix.c: diff -r 3e52d0a8ca3d -r f45199815d5d src/fileio.c --- a/src/fileio.c Fri Apr 06 14:14:46 2018 +0100 +++ b/src/fileio.c Sat Apr 07 21:40:47 2018 +0100 ＠＠ -1495,10 +1495,7 ＠＠ (filename)) { /* This function can GC. GC checked 2000-07-28 ben. */ - Ibyte *nm; - - Ibyte *s, *p, *o, *x, *endp, *got; - Ibyte *target = 0; + Ibyte *nm, *s, *p, *o, *x, *endp, *got, *target = 0; int total = 0; int substituted = 0, seen_braces; Ibyte *xnm; ＠＠ -2897,17 +2894,17 ＠＠ int speccount; struct gcpro gcpro1, gcpro2, gcpro3, gcpro4; Lisp_Object val; - int total; + Bytecount total; Ibyte *read_buf = alloca_ibytes (READ_BUF_SIZE); int mc_count; struct buffer *buf = current_buffer; Lisp_Object curbuf; - int not_regular = 0; - int do_speedy_insert = + Boolint not_regular = 0, do_speedy_insert = coding_system_is_binary (Fget_coding_system (codesys)); if (buf->base_buffer && ! NILP (visit)) - invalid_operation ("Cannot do file visiting in an indirect buffer", Qunbound); + invalid_operation ("Cannot do file visiting in an indirect buffer", + Qunbound); /* No need to call Fbarf_if_buffer_read_only() here. That's called in begin_multiple_change() or wherever. */ ＠＠ -2977,12 +2974,12 ＠＠ #endif /* S_IFREG */ if (!NILP (start)) - CHECK_FIXNUM (start); + CHECK_NATNUM (start); else start = Qzero; if (!NILP (end)) - CHECK_FIXNUM (end); + CHECK_NATNUM (end); if (fd < 0) { ＠＠ -2997,20 +2994,21 ＠＠ record_unwind_protect (close_file_unwind, make_fixnum (fd)); - /* Supposedly happens on VMS. */ - if (st.st_size < 0) - signal_error (Qfile_error, "File size is negative", Qunbound); - if (NILP (end)) { if (!not_regular) { - end = make_fixnum (st.st_size); - if (XFIXNUM (end) != st.st_size) - out_of_memory ("Maximum buffer size exceeded", Qunbound); + end = make_integer (st.st_size); + CHECK_NATNUM (end); } } + /* Supposedly happens on VMS. */ + if (NILP (end) && st.st_size < 0) + { + signal_error (Qfile_error, "File size is negative", Qunbound); + } + /* If requested, replace the accessible part of the buffer with the file contents. Avoid replacing text at the beginning or end of the buffer that matches the file contents; ＠＠ -3097,8 +3095,8 ＠＠ match the text at the end of the buffer. */ while (1) { - int total_read, nread; - Charcount charbpos, curpos, trial; + Bytecount total_read, nread; + OFF_T charbpos, curpos, trial; /* At what file position are we now scanning? */ curpos = st.st_size - (BUF_ZV (buf) - same_at_end); ＠＠ -3146,8 +3144,8 ＠＠ same_at_end += overlap; /* Arrange to read only the nonmatching middle part of the file. */ - start = make_fixnum (same_at_start - BUF_BEGV (buf)); - end = make_fixnum (st.st_size - (BUF_ZV (buf) - same_at_end)); + start = make_integer (same_at_start - BYTE_BUF_BEGV (buf)); + end = make_integer (st.st_size - (BYTE_BUF_ZV (buf) - same_at_end)); buffer_delete_range (buf, same_at_start, same_at_end, !NILP (visit) ? INSDEL_NO_LOCKING : 0); ＠＠ -3158,24 +3156,75 ＠＠ if (!not_regular) { - total = XFIXNUM (end) - XFIXNUM (start); + Lisp_Object args[] = { end, start }; + Lisp_Object diff = Fminus (countof (args), args); /* Make sure point-max won't overflow after this insertion. */ - if (total != XFIXNUM (make_fixnum (total))) - out_of_memory ("Maximum buffer size exceeded", Qunbound); + if (FIXNUMP (diff)) + { + total = XREALFIXNUM (diff); + } +#ifdef HAVE_BIGNUM + else if (bignum_fits_emacs_int_p (XBIGNUM_DATA (diff))) + { + total = bignum_to_emacs_int (XBIGNUM_DATA (diff)); + } +#endif + else + { + /* Doesn't fit in an EMACS_INT, which means doesn't fit in a + Bytecount, which means we should error. */ + goto unreasonably_large; + } + + if ((total > ((Bytecount) (~((EMACS_UINT) 0) >> 1)))) + { + unreasonably_large: + out_of_memory ("Maximum buffer byte size exceeded", + diff); + } } else /* For a special file, all we can do is guess. The value of -1 will make the stream functions read as much as possible. */ total = -1; - if (XFIXNUM (start) != 0 + if (!(EQ (start, Qzero)) /* why was this here? asked jwz. The reason is that the replace-mode connivings above will normally put the file pointer other than where it should be. */ || (!NILP (replace) && do_speedy_insert)) { - if (lseek (fd, XFIXNUM (start), 0) < 0) + OFF_T starting; + + if (FIXNUMP (start)) + { + starting = XREALFIXNUM (start); + } +#ifdef HAVE_BIGNUM + else if (bignum_fits_emacs_int_p (XBIGNUM_DATA (start))) + { + starting = bignum_to_emacs_int (XBIGNUM_DATA (start)); + } + else if (sizeof (starting) == sizeof (long long) + && bignum_fits_llong_p (XBIGNUM_DATA (start))) + { + starting = bignum_to_llong (XBIGNUM_DATA (start)); + } + else if (sizeof (starting) == sizeof (unsigned long long) + && bignum_fits_ullong_p (XBIGNUM_DATA (start))) + { + starting = bignum_to_ullong (XBIGNUM_DATA (start)); + } +#endif + else + { + signal_error (Qunimplemented, + "File offset not supported in this XEmacs", + start); + } + + if (lseek (fd, starting, 0) < 0) report_file_error ("Setting file position", filename); } diff -r 3e52d0a8ca3d -r f45199815d5d src/insdel.c --- a/src/insdel.c Fri Apr 06 14:14:46 2018 +0100 +++ b/src/insdel.c Sat Apr 07 21:40:47 2018 +0100 ＠＠ -1079,10 +1079,6 ＠＠ is a string. */ #endif - /* Make sure that point-max won't exceed the size of an emacs int. */ - if ((length + BUF_Z (buf)) > MOST_POSITIVE_FIXNUM) - out_of_memory ("Maximum buffer size exceeded", Qunbound); - /* theoretically not necessary -- caller should GCPRO. #### buffer_insert_from_buffer_1() doesn't! */ GCPRO1 (reloc); ＠＠ -1129,6 +1125,12 ＠＠ #endif /* ERROR_CHECK_TEXT */ } + /* Make sure that point-max won't exceed the size of an emacs int. */ + if ((MOST_POSITIVE_FIXNUM - 1) - BUF_Z (buf) < cclen) + { + out_of_memory ("Maximum buffer size exceeded", Qunbound); + } + /* &&#### Here we check if the text can't fit into the format of the buffer, and if so convert it to another format (either default or 32-bit-fixed, according to some flag; if no flag, use default). */ diff -r 3e52d0a8ca3d -r f45199815d5d src/lstream.c --- a/src/lstream.c Fri Apr 06 14:14:46 2018 +0100 +++ b/src/lstream.c Sat Apr 07 21:40:47 2018 +0100 ＠＠ -1232,7 +1232,7 ＠＠ should start at. COUNT is the number of bytes to be read (it is ignored when writing); -1 for unlimited. */ static Lisp_Object -make_filedesc_stream_1 (int filedesc, int offset, int count, int flags, +make_filedesc_stream_1 (int filedesc, OFF_T offset, Bytecount count, int flags, tls_state_t *state) { Lstream *lstr = Lstream_new (lstream_filedesc, ＠＠ -1271,16 +1271,16 ＠＠ */ Lisp_Object -make_filedesc_input_stream (int filedesc, int offset, int count, int flags, - tls_state_t *state) +make_filedesc_input_stream (int filedesc, OFF_T offset, Bytecount count, + int flags, tls_state_t *state) { return make_filedesc_stream_1 (filedesc, offset, count, flags | LSTR_READ, state); } Lisp_Object -make_filedesc_output_stream (int filedesc, int offset, int count, int flags, - tls_state_t *state) +make_filedesc_output_stream (int filedesc, OFF_T offset, Bytecount count, + int flags, tls_state_t *state) { return make_filedesc_stream_1 (filedesc, offset, count, flags | LSTR_WRITE, state); diff -r 3e52d0a8ca3d -r f45199815d5d src/lstream.h --- a/src/lstream.h Fri Apr 06 14:14:46 2018 +0100 +++ b/src/lstream.h Sat Apr 07 21:40:47 2018 +0100 ＠＠ -507,10 +507,12 ＠＠ Lisp_Object make_stdio_input_stream (FILE *stream, int flags); Lisp_Object make_stdio_output_stream (FILE *stream, int flags); -Lisp_Object make_filedesc_input_stream (int filedesc, int offset, int count, - int flags, tls_state_t *state); -Lisp_Object make_filedesc_output_stream (int filedesc, int offset, int count, - int flags, tls_state_t *state); +Lisp_Object make_filedesc_input_stream (int filedesc, OFF_T offset, + Bytecount count, int flags, + tls_state_t *state); +Lisp_Object make_filedesc_output_stream (int filedesc, OFF_T offset, + Bytecount count, int flags, + tls_state_t *state); void filedesc_stream_set_pty_flushing (Lstream *stream, int pty_max_bytes, Ibyte eof_char); -- ‘As I sat looking up at the Guinness ad, I could never figure out / How your man stayed up on the surfboard after forty pints of stout’ (C. Moore)