11:58 a.m.
> "Eli" == Eli Zaretskii <eliz(a)gnu.org> writes:
> From: Uwe Brauer <oub(a)mat.ucm.es>
> Cc: Uwe Brauer <uwe.brauer(a)xemacs.org>, xemacs-patches(a)xemacs.org
> Date: Tue, 01 Apr 2014 18:42:19 +0200
>
> However in the hebrew.el file itself there is no author mentioned.
Then I probably should ask you where did you get the file you
modified. The author _is_ mentioned in the file that is in the GNU
Emacs repository, since July 2011. Since you submitted the file to
XEmacs much later, I wonder where did you find the file without that
note.
I checked hebrew.el in my GNU emacs24 installation and you are right the
author is there. I don't remember exactly, but I think one problem was
the coding. I was advised to use iso-2022-7bit, encoding and there was
an incompatibility between GNU emacs and Xemacs. So I think I ended up
copying code of the GNU emacs hebrew.el into an older hebrew.el file I
had in my Xemacs directory (obviously without the author in the
header). Whether this version is also from GNU emacs or corresponds to
an older Xemacs version from 21.4 I do not remember, most likely it was
an old GNU emacs version.
> May I suggest to add it right there and not bury it in some
> ChangeLog files? That would avoid these sort of misunderstandings.
This file does have the attribution inside it. However, in many
other
cases, certainly when only a few functions are copied, the credits are
only in the ChangeLogs. My suggestion was to also grep those in order
to find the original contributor(s).
Well but then you would not name these authors in the corresponding
files but want use to do so?
Thanks.
I submit a changed hebrew file.
Uwe
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
2:56 p.m.
New subject: Credits for imported files
Uwe Brauer writes:
>> "Eli" == Eli Zaretskii <eliz(a)gnu.org>
writes:
>> May I suggest to add it right there and not bury it in
some
>> ChangeLog files? That would avoid these sort of misunderstandings.
> This file does have the attribution inside it. However, in many other
> cases, certainly when only a few functions are copied, the credits are
> only in the ChangeLogs. My suggestion was to also grep those in order
> to find the original contributor(s).
This is too much effort to ask of somebody else -- a person who thinks
it should be done, should do it themselves. If it's fairly easy to
find a main author, I agree, that's worth adding to the file itself
(despite the typical Emacs practice -- Emacs has a separate file,
AUTHORS IIRC, for attributing contributions). If an author shows up
and requests credit, that's fine too, you should add them. (Perhaps
in European law you have to, I don't understand the special "moral
rights of authors" very well.) Trawling the Emacs changelogs, no, you
needn't go that far (but if you want to I encourage you to credit
those authors in the file).
However, there is a real problem with the file you submitted in a
separate post: the copyright notice(s) seem to be missing. Since
it's apparently in GNU Emacs, most of it is probably copyright FSF.
If you mixed with another file, there may be other copyright holders.
Transforming to a different encoding and the other small changes you
made as I understand it are not copyrightable, so you shouldn't add
yourself. (If I misunderstand your contribution, let me know.)
Anyway, please restore any applicable copyright notices (or just post
them here).
Steve
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
4:50 p.m.
New subject: Credits for imported files
> "Stephen" == Stephen J Turnbull
<stephen(a)xemacs.org> writes:
Uwe Brauer writes:
However, there is a real problem with the file you submitted in a
separate post: the copyright notice(s) seem to be missing. Since
it's apparently in GNU Emacs, most of it is probably copyright FSF.
If you mixed with another file, there may be other copyright holders.
Transforming to a different encoding and the other small changes you
made as I understand it are not copyrightable, so you shouldn't add
yourself. (If I misunderstand your contribution, let me know.)
I added two new input methods.
- both are qwerty type of key distributions (meaning a is mapped to
aleph etc). One is based on the one found in xkb, which is
shipped by most X.org distributions. The other one is based on my
private preferences.
- I suggested to add them to the GNU emacs hebrew.el, Stefan
agreed, but then I had to sign copyright assignments to the FSF
which meant sending a snmail to the US, which looked to much
trouble for me.
The lines in hebrew.el which refer to any copyright are:
,----
|
| ;; hebrew.el --- Quail package for inputting Hebrew characters
-*-coding: iso-2022-7bit;-*-
|
| ;; Copyright (C) 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007,
| ;; 2008, 2009, 2010, 2011
| ;; National Institute of Advanced Industrial Science and Technology
(AIST)
| ;; Registration Number H14PRO021
|
| ;; Many input methods in this file provided
| ;; by Yair Friedman <yair.f.lists(a)gmail.com>
|
| ;; Keywords: multilingual, input method, Hebrew
|
| ;; This file is part of GNU Emacs.
|
| ;; GNU Emacs is free software: you can redistribute it and/or modify
| ;; it under the terms of the GNU General Public License as published by
| ;; the Free Software Foundation, either version 3 of the License, or
| ;; (at your option) any later version.
|
| ;; GNU Emacs is distributed in the hope that it will be useful,
| ;; but WITHOUT ANY WARRANTY; without even the implied warranty of
| ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
| ;; GNU General Public License for more details.
|
| ;; You should have received a copy of the GNU General Public License
| ;; along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>;.
|
| ;;; Commentary:
|
| ;;; Code:
`----
Uwe
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
10:51 a.m.
New subject: Credits for imported files
Uwe Brauer writes:
I added two new input methods.
- both are qwerty type of key distributions (meaning a is mapped to
aleph etc). One is based on the one found in xkb, which is
shipped by most X.org distributions.
That should probably have a copyright added, then.
The other one is based on my private preferences.
That means your copyright should be added.
- I suggested to add them to the GNU emacs hebrew.el, Stefan
agreed, but then I had to sign copyright assignments to the FSF
which meant sending a snmail to the US, which looked to much
trouble for me.
Well, in XEmacs that's a matter of personal preference and
convenience, but if it makes a difference I think it's a good idea.
| ;; Copyright (C) 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2006,
2007,
| ;; 2008, 2009, 2010, 2011
This can be abbreviated to "Copyright (C) 1999-2011" according to the
FSF lawyers. Please do (or one of us will).
| ;; National Institute of Advanced Industrial Science and
Technology
(AIST)
| ;; Registration Number H14PRO021
That's weird (AIST is a Japanese government organization, why they
would be contributing on an annual basis, and no FSF? was Friedman an
AIST employee?) I supppose this might just be a hangover from one of
the original quail files. I wouldn't worry about it beyond that (it's
a GNU screwup if anything), but at least we should try to preserve
copyright notices as we receive them.
I'll try to get to this this weekend, if nobody beats me to it.
Steve
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
3:58 p.m.
New subject: Credits for imported files
From: "Stephen J. Turnbull" <stephen(a)xemacs.org>
Cc: Eli Zaretskii <eliz(a)gnu.org>,
xemacs-patches(a)xemacs.org,
uwe.brauer(a)xemacs.org
Date: Thu, 03 Apr 2014 18:51:56 +0900
> | ;; National Institute of Advanced Industrial Science and Technology
> (AIST)
> | ;; Registration Number H14PRO021
That's weird (AIST is a Japanese government organization, why they
would be contributing on an annual basis, and no FSF?
AFAIK, that comes from some special arrangement AIST had with the FSF.
I don't know the details, but I guess Handa-san is still much closer
to you than to me, so you should be able to ask him directly.
was Friedman an AIST employee?
No, never.
The AIST copyright is there because the original hebrew.el, with a
single input method (the 1st one), was written by Handa-san or maybe
someone else at AIST.
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
5:39 p.m.
New subject: Credits for imported files
From: "Stephen J. Turnbull" <stephen(a)xemacs.org>
Cc: Eli Zaretskii <eliz(a)gnu.org>,
xemacs-patches(a)xemacs.org,
uwe.brauer(a)xemacs.org
Date: Wed, 02 Apr 2014 22:56:13 +0900
Uwe Brauer writes:
> >> "Eli" == Eli Zaretskii <eliz(a)gnu.org> writes:
> >> May I suggest to add it right there and not bury it in some
> >> ChangeLog files? That would avoid these sort of misunderstandings.
>
> > This file does have the attribution inside it. However, in many other
> > cases, certainly when only a few functions are copied, the credits are
> > only in the ChangeLogs. My suggestion was to also grep those in order
> > to find the original contributor(s).
This is too much effort to ask of somebody else -- a person who thinks
it should be done, should do it themselves. If it's fairly easy to
find a main author, I agree, that's worth adding to the file itself
I was only talking about importing whole files or functions or major
features (which are groups of newly introduced functions). For these,
grepping the ChangeLog files for the earliest entry is usually enough.
(despite the typical Emacs practice -- Emacs has a separate file,
AUTHORS IIRC, for attributing contributions).
AUTHORS in GNU Emacs is a derived file: it is produced by scanning
ChangeLogs and an auxiliary database in authors.el. So the
information in that file is really stored elsewhere.
Thanks.
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
5:23 p.m.
New subject: Credits for imported files
From: Uwe Brauer <oub(a)mat.ucm.es>
Cc: uwe.brauer(a)xemacs.org, xemacs-patches(a)xemacs.org
Date: Wed, 02 Apr 2014 12:58:40 +0200
>> May I suggest to add it right there and not bury it in some
>> ChangeLog files? That would avoid these sort of misunderstandings.
> This file does have the attribution inside it. However, in many other
> cases, certainly when only a few functions are copied, the credits are
> only in the ChangeLogs. My suggestion was to also grep those in order
> to find the original contributor(s).
Well but then you would not name these authors in the corresponding
files but want use to do so?
My suggestion is to copy the "FOO: New file" or "FOO (BAR): New
function" ChangeLog entries from GNU Emacs together with their
original authors' names into XEmacs ChangeLog. But that is just a
suggestion; you guys should decide on your procedures yourselves.
I submit a changed hebrew file.
Thanks.
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches
3924
days inactive
3925
days old
6 comments
3 participants
participants (3)
-
Eli Zaretskii -
Stephen J. Turnbull -
Uwe Brauer