"Ben Wing" <ben(a)666.com> wrote:
> The function whitespace-cleanup is defined in
> text-modes/whitespace.el, but text-modes was not added to
> REQUIRES in the Makefile. However, I wonder if this is
> appropriate. At two other places in texinfmt.el, both in the
> context of this patch, whitespace is removed like this:
> (while (re-search-forward "[ \t]+$" nil t)
> (replace-match "" nil nil))
> Is that good enough? If so, we should do the same here
> instead of creating a dependency on text-modes. If not, we
> should change the other two places to call whitespace-cleanup also.
I really don't know. The call to whitespace-cleanup comes from FSF, and I
can't find any mention of it in their ChangeLogs.
Having looked at it for all of 30 seconds, it appears that the while
loop I mentioned is not appropriate at the place where
whitespace-cleanup is called. In that case, Ben, would you add
text-modes to REQUIRES in the texinfo Makefile?