[AC21.5] XE_COMPLEX_ARG variables need to be identifiers
APPROVE COMMIT 21.5
I don't know how I missed this; of course most of the logic testing
was done with a barebones configure.ac and simple option names, but I
did run XEmacs's configure. Which produces a fairly obvious syntax
error, immediately.
Malcolm (and others familiar with configure), I would appreciate
review. This does give the expected results in configure (it only
matters for --with-error-checking). However, I'm not sure the quoting
is optimal, and there are probably better ways to do it. Also, there
are at least two versions of the patsubst macro floating around.
Patch to configure itself is omitted.
Index: ChangeLog
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/ChangeLog,v
retrieving revision 1.481
diff -u -r1.481 ChangeLog
--- ChangeLog 18 Dec 2005 12:21:49 -0000 1.481
+++ ChangeLog 18 Dec 2005 16:13:12 -0000
＠＠ -0,0 +1,5 ＠＠
+2005-12-19 Stephen J. Turnbull <stephen(a)xemacs.org>
+
+ * configure.ac (XE_COMPLEX_ARG): Substitute '_' for '-' in default
+ variable names.
+
Index: configure.ac
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/configure.ac,v
retrieving revision 1.27
diff -u -r1.27 configure.ac
--- configure.ac 18 Dec 2005 12:21:53 -0000 1.27
+++ configure.ac 18 Dec 2005 16:13:17 -0000
＠＠ -515,10 +515,10 ＠＠
$3
],[
# set default for each type
-for y in $_[$1]_types; do
- eval "with_[$1]_$y=\$_[$1]_${y}_default"
- eval "enable_[$1]_$y=\$_[$1]_${y}_default"
- unset _[$1]_${y}_default
+for y in [$_]patsubst([$1], -, _)[_types]; do
+ eval "[with_]patsubst([$1], -, _)[_$y]=[\$_]patsubst([$1], -,
_)[_${y}_default]"
+ eval "[enable_]patsubst([$1], -, _)[_$y]=[\$_]patsubst([$1], -,
_)[_${y}_default]"
+ unset [_]patsubst([$1], -, _)[_${y}_default]
done
$4])])dnl
dnl
--
School of Systems and Information Engineering http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.