Re: [Q] Always use boyer_moore in ASCII or Latin-1 buffers with ASCII search strings
Ar an seachtú lá is fiche de mí na Nollaig, scríobh Stephen J. Turnbull:
QUERY
Aidan Kehoe writes:
> - /* &&#### needs some 8-bit work here */
Have you talked about this to Ben to confirm that this is the problem
he had in mind?
Ben, this is in reference to
http://mid.gmane.org/18290.33287.387191.561174＠parhasard.net , which cleaned
up all the non-ASCII logic I could find in search.c . Do you remember what
exactly you meant with that comment?
> + if (ch > 0x7F &&
buffer_entirely_one_byte_p)
> + continue;
> +
> + if (ch > 0xFF && buffer_nothing_greater_than_0xff)
> + continue;
At least in the leading case of case-insensitive search, these should
be asserts for the sake of debugging. Are you sure they can't be?
They shouldn’t be; we allow non-ASCII characters to be case variants of
ASCII characters, as Unicode specifies.
(I’ve committed this change, by the way.)
--
¿Dónde estará ahora mi sobrino Yoghurtu Nghé, que tuvo que huir
precipitadamente de la aldea por culpa de la escasez de rinocerontes?
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches