Mike Kupfer writes:
Stephen J. Turnbull wrote:
> + There are only (octal) 0200 ASCII characters, and only 128 values
> + supplied in the definition.
Could we use a #define instead of replicating 0200 everywhere?
E.g., in syntax.h
#define NUMSYNTAXCODES 0200
extern const unsigned char syntax_spec_code[NUMSYNTAXCODES];
In search.c:
if (c < NUMSYNTAXCODES && syntax_spec_code[c] < (unsigned char) Smax)
(etc.)
I won't veto that change, but there is no "etc" (the value is used
only in the declaration and definition of the array, and that one
place in search.c), so I don't see a need to actually do it.
I think there probably a #define for 128/0200/0x80 somewhere in the
text.* or *coding.* files, if so, maybe that should be used.
An amusing (but inadvisable :-) approach would be
enum ascii_codes {
NUL, /* null character, string terminator */
SOH, /* start of header, used in Babyl mail files */
...
A, /* UPPERCASE LATIN LETTER A */
...
MAXASCII /* upper bound for ASCII characters */
};
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches