Re: Identify XEmacs build from Mercurial changeset
"Stephen J. Turnbull" <stephen(a)xemacs.org> writes:
BTW, it occurs to me that the whole approach of setting this in
version.sh is probably excessively complicated. We did it that way
originally because it was done on the server. Would it be more
portable to just set a variable
XEMACS_HG_NODEID=`hg identify`
in the Makefile and add `-DXEMACS_EXTRA_NAME=" (+hg:${XEMACS_HG_NODEID})"'
to CFLAGS or so?
How so? How would it work on Windows?
There's nothing that horrible with a little redundancy
xemacs_extra_name=
xemacs_extra_name="hg:abcdef0123"
for Windows, is there?
I don't understand what exactly you're proposing. Could you elaborate?
The *code* in my suggestion is fragile, but once it works there's
no
reason to change it ever, unless you change the name of the option or
the whole file format. The file format in yours is fragile in itself;
it depends on ordering and lack of a trailing newline. It's also not
extensible to a second keyword.
I know. I just don't know how to do it better.
> > What's the deal with ${srcdir}/extra-name? I don't see how that can
> > get initialized to anything sensible,
>
> It should get initialized when a tarball release.
I don't like that. The point of xemacs_extra_name is to flag
non-release builds.
Maybe I missed something---do beta releases count as relases. How are
they flagged? (It's probably been 10+ years since I downloaded a beta
tarball.)
I agree that we should know the revision that the
release was built from, but we already know that: it's tagged
with an
identifier built from the version number, which is reserved to the
maintainer and unique by construction.
> Well, what I have *does* say *if* there are local modifications. I
> think this should be enough for most purposes.
To be pedantic, it doesn't tell you that, because the repo is by
definition local. You do not know whether the particular revision is
available anywhere else.
But we do know whether the revision comes from us.
--
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches