[COMMIT] Specify ERROR_ME_WARN explicitly in specifier_instance_from_inst_list().
Giacomo, in my local tests, this fixes the gnuclient problem you were
seeing. There is still a warning about the attempt to instantiate a pixmap
specifier on a TTY; this warning is probably wrong, and I’ll fix it
at some point, but this should be good enough for most purposes now.
APPROVE COMMIT
NOTE: This patch has been committed.
# HG changeset patch
# User Aidan Kehoe <kehoea(a)parhasard.net>
# Date 1288025857 -3600
# Node ID d185fa593d5fcf818ca0d27e53374348d936d7e8
# Parent 2474dce7304ec92f72eb42d0156ba0134aa9f6ee
Specify ERROR_ME_WARN explicitly in specifier_instance_from_inst_list().
src/ChangeLog
2010-10-25 Aidan Kehoe <kehoea(a)parhasard.net>
* specifier.c (specifier_instance_from_inst_list):
Call call_with_suspended_errors() with ERROR_ME_WARN, explicitly;
avoids the problem Giacomo Boffi describes in
http://mid.gmane.org/19617.52517.341117.388679＠aiuole.stru.polimi.it
, but the specifier instantiation bug that makes XEmacs fail for
him is still visible.
diff -r 2474dce7304e -r d185fa593d5f src/ChangeLog
--- a/src/ChangeLog Mon Oct 25 13:15:53 2010 +0100
+++ b/src/ChangeLog Mon Oct 25 17:57:37 2010 +0100
＠＠ -1,3 +1,12 ＠＠
+2010-10-25 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * specifier.c (specifier_instance_from_inst_list):
+ Call call_with_suspended_errors() with ERROR_ME_WARN, explicitly;
+ avoids the problem Giacomo Boffi describes in
+ http://mid.gmane.org/19617.52517.341117.388679＠aiuole.stru.polimi.it
+ , but the specifier instantiation bug that makes XEmacs fail for
+ him is still visible.
+
2010-10-25 Aidan Kehoe <kehoea(a)parhasard.net>
* print.c (ulong_to_bit_string): If printing zero, actually print
diff -r 2474dce7304e -r d185fa593d5f src/specifier.c
--- a/src/specifier.c Mon Oct 25 13:15:53 2010 +0100
+++ b/src/specifier.c Mon Oct 25 17:57:37 2010 +0100
＠＠ -2826,7 +2826,7 ＠＠
if (HAS_SPECMETH_P (sp, instantiate))
val = call_with_suspended_errors
((lisp_fn_t) RAW_SPECMETH (sp, instantiate),
- Qunbound, Qspecifier, errb, 5, specifier,
+ Qunbound, Qspecifier, ERROR_ME_WARN, 5, specifier,
matchspec, domain, val, depth, no_fallback);
if (!UNBOUNDP (val))
--
“Apart from the nine-banded armadillo, man is the only natural host of
Mycobacterium leprae, although it can be grown in the footpads of mice.”
-- Kumar & Clark, Clinical Medicine, summarising improbable leprosy research
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches