Re: [V] Handle macros, autoloads correctly in symbol-file. Add an incomplete TYPE arg.
Ar an dara lá de mí Eanair, scríobh Stephen J. Turnbull:
You could either make the assignment expression the argument of the
SUBRP (but you'd have to check the macro definition for argument
safety), or use the comma operator to sequence.
I ended up checking for nil instead of zero. Your first approach might have
been better, but I’m not going to revise it now :-) .
> > BTW, it looks to me like this probably should be an
assert, but I
> > don't know where to look it up offhand.
>
> No, if I understand you correctly that would make it trivial to crash
> XEmacs from Lisp with:
Fine. But shouldn't
> (progn
> (fset 'whatever '(macro . not-a-subr))
> (built-in-symbol-file 'whatever))
should be caught and handled somehow?
No, people can fuck around with the function definition all they want. It’s
bad practice, but it’s legal Lisp--see for example the autoload
implementation for keymaps.
And ... hm ...
> > > Our load-history doesn't have the relevant metadata.
Do you plan to do anything about the lack of metadata?
Yeah, sync from GNU. Eventually.
--
¿Dónde estará ahora mi sobrino Yoghurtu Nghé, que tuvo que huir
precipitadamente de la aldea por culpa de la escasez de rinocerontes?
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches