[COMMIT] Check absolute source file names against DOC with #'file-newer-than-file-p.
Ar an triochadú lá de mí na Nollaig, scríobh Stephen J. Turnbull:
I'm pretty sure that applying the following patch, then doing:
mkdir what-would-jamie-do
cd what-would-jamie-do
../configure
make
will make the symptoms evident. What to do about it is up to you, I'm
in sympathy with using the relative path but it may not be easy.
Obviously, breaking configure --srcdir isn't acceptable. I append the
M-x report-xemacs-bug output for posterity's sake.
OK, fixed--the API of #'file-new-than-file-p is stupidly unintuitive, I
smell the work of a MacArthur genius. Thanks for the report!
# HG changeset patch
# User Aidan Kehoe <kehoea(a)parhasard.net>
# Date 1230653399 0
# Node ID ab9e8f0fb295d0d0a41062759eff5d77be652c64
# Parent 44129f301385e892320cacced2696acdbdf6a1df
Check absolute source file names against DOC with #'file-newer-than-file-p.
2008-12-30 Aidan Kehoe <kehoea(a)parhasard.net>
* make-docfile.el:
Use absolute source file names when checking if DOC is out of
date, don't use relative paths that may not be related to the
current directory.
diff -r 44129f301385 -r ab9e8f0fb295 lisp/ChangeLog
--- a/lisp/ChangeLog Tue Dec 30 14:22:29 2008 +0000
+++ b/lisp/ChangeLog Tue Dec 30 16:09:59 2008 +0000
＠＠ -1,3 +1,10 ＠＠
+2008-12-30 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * make-docfile.el:
+ Use absolute source file names when checking if DOC is out of
+ date, don't use relative paths that may not be related to the
+ current directory.
+
2008-12-30 Aidan Kehoe <kehoea(a)parhasard.net>
* frame.el (display-mouse-p):
diff -r 44129f301385 -r ab9e8f0fb295 lisp/make-docfile.el
--- a/lisp/make-docfile.el Tue Dec 30 14:22:29 2008 +0000
+++ b/lisp/make-docfile.el Tue Dec 30 16:09:59 2008 +0000
＠＠ -151,7 +151,7 ＠＠
(load "setup-paths.el")
(load "raw-process.el")
-(let (preloaded-file-list arg0 arg package-preloaded-file-list)
+(let (preloaded-file-list arg0 arg package-preloaded-file-list absolute)
(load (expand-file-name "dumped-lisp.el" source-lisp))
(setq package-preloaded-file-list
＠＠ -168,7 +168,8 ＠＠
(while preloaded-file-list
(setq arg0 (packages-add-suffix (car preloaded-file-list))
- arg (locate-library arg0))
+ arg (locate-library arg0)
+ absolute arg)
(if (null arg)
(progn
(message "Error: dumped file %s does not exist" arg0)
＠＠ -191,7 +192,8 ＠＠
(if (null (member arg processed))
(progn
(if (and (null docfile-out-of-date)
- (file-newer-than-file-p arg docfile))
+ ;; We need to check the absolute path here:
+ (file-newer-than-file-p absolute docfile))
(setq docfile-out-of-date t))
(setq processed (cons arg processed)))))
(setq preloaded-file-list (cdr preloaded-file-list))))
--
¿Dónde estará ahora mi sobrino Yoghurtu Nghé, que tuvo que huir
precipitadamente de la aldea por culpa de la escasez de rinocerontes?
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches