21.5
Will commit after a couple days if no objections.
The name "Lstream_pseudo_close" has annoyed me for a decade (it's
nothing of the kind), and it's time to swat this gnat. :-) It's a
static function, called in two places (and one of those is `#if 0'ed
out:-), so it shouldn't bother anything but somebody's sense of
aesthetics.
diff -r 2dbefd79b3d3 -r 52de3c8a7f41 src/ChangeLog
--- a/src/ChangeLog Sat Oct 29 01:10:32 2011 +0900
+++ b/src/ChangeLog Sat Oct 29 01:39:55 2011 +0900
@@ -1,3 +1,8 @@
+2011-10-29 Stephen J. Turnbull <stephen(a)xemacs.org>
+
+ * lstream.c (Lstream_flush_safely): Renamed from Lstream_pseudo_close.
+ (disksave_lstream, Lstream_close): Fix calls.
+
2011-10-29 Stephen J. Turnbull <stephen(a)xemacs.org>
Prevent SIGPIPEs in deactivate_process().
diff -r 2dbefd79b3d3 -r 52de3c8a7f41 src/lstream.c
--- a/src/lstream.c Sat Oct 29 01:10:32 2011 +0900
+++ b/src/lstream.c Sat Oct 29 01:39:55 2011 +0900
@@ -86,7 +86,7 @@
Lstream *lstr = XLSTREAM (lstream);
#if 0 /* this may cause weird Broken Pipes? */
- Lstream_pseudo_close (lstr);
+ Lstream_flush_safely (lstr);
return;
#endif
if ((lstr->flags & LSTREAM_FL_IS_OPEN) &&
@@ -782,7 +782,7 @@
}
static int
-Lstream_pseudo_close (Lstream *lstr)
+Lstream_flush_safely (Lstream *lstr)
{
if (! (lstr->flags & LSTREAM_FL_IS_OPEN))
Lstream_internal_error ("lstream is not open", lstr);
@@ -844,7 +844,7 @@
if (lstr->flags & LSTREAM_FL_IS_OPEN)
{
- rc = Lstream_pseudo_close (lstr);
+ rc = Lstream_flush_safely (lstr);
/*
* We used to return immediately if the closer method reported
* failure, leaving the stream open. But this is no good, for
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-patches