Re: [Q] respect CODESYS in `insert-file-contents-internal'.
On 26 Jan 2007, Stephen J. Turnbull verbalised:
QUERY
Nix writes:
> Indeed. Here's the patch again, against fairly recent 21.5 CVS.
>
> 2005-02-04 Nix <nix(a)esperi.org.uk>
>
> * fileio.c (restore_read_coding_system_unwind): Pop the coding
> system.
> (Finsert_file_contents_internal): Use the CODESYS even for files
> read by a file-name-handler.
Eh, I trust you, but could you like provide me a clue? I mean, why do
you need to set Vcoding_system_for_read in a *write* function?
(Hang on, did the line numbers get frotzed in there?
insert-file-contents-internal isn't a write function!)
... hm. Patch fuzz, most profound apologies: you're right that the patch
as supplied makes no sense... and upon further inspection the respinning
of more of insert_file_contents_internal into Lisp has fixed this
problem as a side-effect. So it's no longer a bug in 21.5. Sorry,
discard the patch by all means.
(The underlying problem in 21.4 was that insert_file_contents didn't
actually *change* the coding system in use to that specified by the
CODESYS, but *did* call the file-name-handlers, so the handlers ended up
applying whatever the default coding system was. For raw binary data,
e.g. that specified in the :data part of an image specifier, this was
often a very bad thing.)
--
`The serial comma, however, is correct and proper, and abandoning it will
surely lead to chaos, anarchy, rioting in the streets, the Terrorists
taking over, and possibly the complete collapse of Human Civilization.'
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches