Nelson Ferreira <nelson.ferreira(a)ieee.org> writes:
Hi all,
I suppose I must be one of the very few using BBDB with erc, because
by default the erc-bbdb package exhibits a veryu annoying behavior I
find hard to believe people like:
* When showing the BBDB popup, the BBDB buffer is electric which
means that it captures the keyboard "focus" and basically
prevents updates to the channel buffer.
* Specially annoying when a lot of the people in the channel are
known to you and you are joining.
The patch adds a customize option to control this behavior (I think
off is the right default, but feel free to put it as t for backwards
compatibility.)
Hello Nelson,
I saw you submitting this patch upstream
(erc-help(a)lists.sourceforge.net) in the meantime, which was the right
thing to do.
I am currently tracking upstream
release_5_1_branch
with the XEmacs erc package.
Have you noticed erc actually has texinfo documentation now?
(info "(erc)Getting Help and Reporting Bugs")
Best regards,
Adrian
With erc-bbdb-electric-p set to nil, the bbdb buffer is no longer
electric and it does not block progress.
Thanks,
Nelson
Index: erc-bbdb.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/erc/erc-bbdb.el,v
retrieving revision 1.7
diff -u -d -u -b -r1.7 erc-bbdb.el
--- erc-bbdb.el 2006/02/19 12:57:27 1.7
+++ erc-bbdb.el 2006/03/16 04:53:14
@@ -113,6 +113,11 @@
:group 'erc-bbdb
:type 'boolean)
+(defcustom erc-bbdb-electric-p nil
+ "If t, BBDB popup buffer is electric."
+ :group 'erc-bbdb
+ :type 'boolean)
+
(defun erc-bbdb-search-name-and-create (create-p name nick finger-host silent)
(let* ((ircnick (cons erc-bbdb-irc-nick-field (concat "^"
(regexp-quote nick))))
@@ -133,7 +138,8 @@
record)))
(defun erc-bbdb-show-entry (record channel proc)
- (let ((bbdb-display-layout (bbdb-grovel-elide-arg erc-bbdb-elide-display)))
+ (let ((bbdb-display-layout (bbdb-grovel-elide-arg erc-bbdb-elide-display))
+ (bbdb-electric-p erc-bbdb-electric-p))
(when (and record (or (eq erc-bbdb-popup-type t)
(and (eq erc-bbdb-popup-type 'visible)
(and channel
--
Adrian Aichner
mailto:adrian@xemacs.org
http://www.xemacs.org/