[AC21.5] Restore missing paren in sunpro.c, fix build
APPROVE COMMIT 21.5
Not needed for 21.4. Tested with success by Paul Keusemann, so in we
go.
Stephen J. Turnbull writes:
Paul Keusemann writes:
> I sent in a patch for this in October 2005. I've attached a current
> diff. Not sure the last time I updated from CVS.
It's still valid. I prefer Rob's suggested patch though, because the
conditionalized code is syntactically a unit.
> > Does the feature actually work?
>
> I haven't actually used it in a while but I believe it still does.
Well, there doesn't seem to be a way to configure it short of directly
hacking src/config.h; config.h.in says it's undocumented and probably
not used. (Martin, do you have idea about this stuff?)
Could you try configuring
--with-sparcworks --with-usage-tracking
and tell me what
grep "SUNPRO\|USAGE_TRACKING" src/config.h
says? A test that the patch applies and builds would be greatly
appreciated too.
> > > Secondly linking temacs fails with:
Any news on the link failure?
Index: src/ChangeLog
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/ChangeLog,v
retrieving revision 1.1077
diff -u -r1.1077 ChangeLog
--- src/ChangeLog 26 Jul 2007 11:15:04 -0000 1.1077
+++ src/ChangeLog 4 Aug 2007 05:22:05 -0000
＠＠ -0,0 +1,6 ＠＠
+2007-08-04 Stephen J. Turnbull <stephen(a)xemacs.org>
+
+ * sunpro.c (Fut_log_text): Fix mismatched parentheses, reorganize.
+ Thanks to Paul Keusemann (for a suggested patch) and Rob McMahon
+ for reporting the issue.
+
Index: src/sunpro.c
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/sunpro.c,v
retrieving revision 1.3
diff -u -r1.3 sunpro.c
--- src/sunpro.c 20 Sep 2004 19:20:00 -0000 1.3
+++ src/sunpro.c 4 Aug 2007 05:22:05 -0000
＠＠ -21,6 +21,12 ＠＠
/* Synched up with: Not in FSF. */
+/* Commentary:
+
+According to Paul Keusemann in <20070802140358.GA19566(a)visi.com>, this
+feature probably still works as of 2007-08-02. However, that doesn't seem
+reliable since there doesn't seem to be a way to configure it! */
+
#include <config.h>
#include "lisp.h"
＠＠ -51,6 +57,7 ＠＠
#else
(int UNUSED (nargs), Lisp_Object *UNUSED (args))
#endif
+ )
{
#ifdef USAGE_TRACKING
Lisp_Object xs;
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches