Re: [PATCH 21.5] -Wdeclaration-after-statement support

Jerry> I am interested in finding out whether this approach is Jerry> acceptable to the other developers. +1 on the approach. Jerry> In particular, is the $(( ... )) syntax okay? ash, which was the default /bin/sh on at least some Debian systems[1], is buggy, at least in version 0.5.3-3. if test $((__GCC)) -ge 3; then echo not smaller; else echo smaller; fi gives 'ash: arith: syntax error: "__GCC"', while if test $(($__GCC)) -ge 3; then echo not smaller; else echo smaller; fi gives "not smaller". (Note the extra '$' in the second command.) Blech. I don't see a good reason to use the $((expr))syntax instead of ordinary variable substitution. All of zsh 4.2.5, (Debian) ash 0.5.3-3, and bash 3.1.14(1)-release work with 'test "$__GCC" -ge 3' for numerical values of __GCC. The conf programs presumably are guaranteed to give numerical output for any usable version of gcc, right? Footnotes: [1] At one point Debian was trying to flush out bash-isms. This may no longer be relevant. -- School of Systems and Information Engineering http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Ask not how you can "do" free software business; ask what your business can "do for" free software.