VETO
But I mean that in the friendliest possible way.
Ben Wing <ben(a)xemacs.org> wrote:
src/ChangeLog addition:
2005-01-26 Ben Wing <ben(a)xemacs.org>
* free-hook.c (check_free):
Fix aliasing warning.
Sorry, Ben. I promised you I'd look into this quite awhile ago, but I
never got back to you. Mea culpa. I just did and this patch is
definitely incorrect. I am not surprised that it fools gcc into
shutting up, but all this patch accomplishes is to make the compiler
stop warning us about dangerous code. It doesn't actually remove the
danger. I am going to continue being very busy through the weekend, and
probably into Monday of next week, but I promise, cross my heart, I'll
come up with a fix right after that.
For the interested, the C99 Rationale explains the problem and what
compilers are allowed and required to do. See
http://www.open-std.org/jtc1/sc22/wg14/www/C99RationaleV5.10.pdf,
specifically section 6.5, starting at the bottom of page 59, and section
6.7.3.1, page 77.
--
Jerry James
http://www.ittc.ku.edu/~james/