[R21.4] buffer-file-truename vs. info.el [was: Fast lock mode issue]
RECOMMEND 21.4
Vin, please review. The recommendation is based on theory; I will be
testing, and Nelson too, I guess.
A separate patch will be submitted for 21.5, because 21.4 setqs
Info-index-alternatives nil, but in 21.5 it's commented out:
;; Nooooooooooo! Info-index can extend across more
;; than one file (e.g. XEmacs, Lispref)
;; Info-index-alternatives nil
I don't understand this comment yet, but maybe the same change should
be applied to 21.4 too? It's a change by Ben according to cvs
annotate. Ben?
Nelson Ferreira writes:
This happens for me mostly when using Info and the info file is
compressed. I believe the root cause of this is because the buffer is
not associated with a file name.
Not quite right. It is associated with a file name, but that code
that does it was faulty.
The issue here seems to be that on
the decompressed bufefr buffer-file-truename is nil and while
buffer-file-name still holds the .gz file name which can be used to
save the font-lock info, but it was not.
Aha! Functions like `find-file' are supposed to maintain the invariant
`(equal buffer-file-truename (file-truename buffer-file-name))', but
info.el failed to do so. The following patch fixes that bug. Will
you check and see if it fixes the symptom for you?
Would you also review your experience briefly, and let me know if you
can think of any other situation where this has happened? I briefly
audited the Lisp code, which seems OK, but the C code is much harder
to review.
_______________________________________________
XEmacs-Patches mailing list
XEmacs-Patches(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-patches