Adrian Aichner <adrian(a)xemacs.org> writes:
As discussed recently.
I intend to commit this tomorrow.
Best regards,
Adrian
xemacs-21.5-clean ChangeLog patch:
Diff command: cvs -q diff -U 0
Files affected: lisp/ChangeLog
Index: lisp/ChangeLog
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/ChangeLog,v
retrieving revision 1.643
diff -u -U0 -r1.643 ChangeLog
--- lisp/ChangeLog 22 Feb 2005 07:16:06 -0000 1.643
+++ lisp/ChangeLog 22 Feb 2005 23:27:40 -0000
@@ -0,0 +1,9 @@
+2005-02-23 Adrian Aichner <adrian(a)xemacs.org>
+
+ * cmdloop.el (keyboard-quit): Remove workaround for
+ `region-active-p' not making sure active region is in current
+ buffer now that it does.
+ * minibuf.el (minibuffer-keyboard-quit): Ditto.
+ * simple.el (region-active-p): `region-active-p' to only return t
+ when active region is in current buffer.
+
APPROVE COMMIT 21.4
Adrian, the patch looks OK, but I couldn't trigger the bug by
highlighting text, switching buffers and calling (region-active-p); it
always returned nil. Of course I noticed that the region was no
longer highlighted when I returned to the original buffer.
Do you think you can generate a test to demonstrate the fix?
In the meantime, I've committed the patch; it will appear in XEmacs
21.4.18, "Constant Variable".
Thanks,
Vin