RE: [AC21.4] sheap.c printf string patch for gcc-3.3.3 on Cygwin
-----Original Message-----
From: Vin Shelton [mailto:acsï¼ xemacs.org]
Sent: Wednesday, January 26, 2005 7:35 PM
To: Ben Wing
Cc: xemacs-patches(a)xemacs.org; 'Dr. Volker Zell'
Subject: Re: [AC21.4] sheap.c printf string patch for
gcc-3.3.3 on Cygwin
"Ben Wing" <ben(a)666.com> writes:
>> APPROVE COMMIT 21.4
>>
>> I actually committed the James variation of the patch. Patch
>> will appear in XEmacs 21.4.17, "Jumbo Shrimp".
>>
>> - Vin
>>
>
> Vin -- it would be better to commit the version that I
sent, not the
> version that you have currently. Using multiple "" strings is the
> ANSI-correct way to do things.
I disagree - the patch I committed is perfectly valid and
could potentially be accepted by more compilers.
Only if they are non-ANSI, which we don't support. In the past we've had
problems with compilers choking on long strings with embedded backslashes,
so "potentially" it could go the other way as well.