User: stephent
Date: 06/05/08 09:35:28
Modified: xemacs/src ChangeLog EmacsShell-sub.c
Log:
Improve DEBUG_GEOMETRY_MANAGEMENT messages.
<87y7xdotzh.fsf(a)tleepslib.sk.tsukuba.ac.jp>
Revision Changes Path
1.957 +6 -0 XEmacs/xemacs/src/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/ChangeLog,v
retrieving revision 1.956
retrieving revision 1.957
diff -u -p -r1.956 -r1.957
--- ChangeLog 2006/05/07 14:20:33 1.956
+++ ChangeLog 2006/05/08 07:35:23 1.957
@@ -1,3 +1,9 @@
+2006-05-08 Stephen J. Turnbull <stephen(a)xemacs.org>
+
+ * EmacsShell-sub.c (RootGeometryManager):
+ Change garbage to useful messages under DEBUG_GEOMETRY_MANAGEMENT.
+ Based on a suggestion by Francois L'Archeveque.
+
2006-05-02 Stephen J. Turnbull <stephen(a)xemacs.org>
* doc.c (extract_object_file_name): Fix buffer overrun.
1.9 +9 -4 XEmacs/xemacs/src/EmacsShell-sub.c
Index: EmacsShell-sub.c
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/EmacsShell-sub.c,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -p -r1.8 -r1.9
--- EmacsShell-sub.c 2006/05/06 17:55:59 1.8
+++ EmacsShell-sub.c 2006/05/08 07:35:25 1.9
@@ -339,11 +339,16 @@ RootGeometryManager (Widget gw,
result == XtGeometryAlmost ? "XtGeometryAlmost" :
"XtGeometryDone");
if (reply->request_mode & CWWidth)
- printf ("width returned;");
+ printf ("width returned was %d%s",
+ reply->width,
+ reply->request_mode & CWHeight ? "; " : ".\n");
if (reply->request_mode & CWHeight)
- printf ("height returned;");
- printf ("\n");
- printf (" resulting shell size: %d %d\n", reply->width,
reply->height);
+ printf ("height returned was %d.\n", reply->height);
+ /* #### does this also need to depend on the result?
+ With XtGeometryYes there doesn't seem to be a useful reply object. */
+ printf (" resulting shell size: %d %d\n",
+ reply->request_mode & CWWidth ? reply->width : w->core.width,
+ reply->request_mode & CWHeight ? reply->height : w->core.height);
printf ("----------\n");
fflush (stdout);
#endif
Show replies by date