User: stephent
Date: 05/10/26 15:01:45
Modified: xemacs/modules/ldap eldap.c
Log:
Warning elimination and documentation improvements.
<878xwgh1u7.fsf(a)tleepslib.sk.tsukuba.ac.jp>
<87d5lsh1xa.fsf(a)tleepslib.sk.tsukuba.ac.jp>
Revision Changes Path
1.47 +8 -0 XEmacs/xemacs/modules/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/modules/ChangeLog,v
retrieving revision 1.46
retrieving revision 1.47
diff -u -p -r1.46 -r1.47
--- ChangeLog 2005/10/25 08:32:40 1.46
+++ ChangeLog 2005/10/26 13:01:37 1.47
@@ -1,3 +1,11 @@
+2005-10-22 Stephen J. Turnbull <stephen(a)xemacs.org>
+
+ Warning elimination:
+
+ * ldap/eldap.c (Fldap_add): Remove declaration of `current', which
+ is now declared by EXTERNAL_LIST_LOOP_2.
+ (Fldap_modify): Remove redundant variable `gcpro2',
+
2005-10-25 Ben Wing <ben(a)xemacs.org>
* postgresql/postgresql.c (allocate_pgconn):
1.877 +4 -0 XEmacs/xemacs/src/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/ChangeLog,v
retrieving revision 1.876
retrieving revision 1.877
diff -u -p -r1.876 -r1.877
--- ChangeLog 2005/10/25 11:19:56 1.876
+++ ChangeLog 2005/10/26 13:01:40 1.877
@@ -1,3 +1,7 @@
+2005-10-22 Stephen J. Turnbull <stephen(a)xemacs.org>
+
+ * lrecord.h: Explain the EXTERNAL_LRECORD macros better.
+
2005-10-25 Ben Wing <ben(a)xemacs.org>
* config.h.in (EXTERN_C):
1.42 +2 -1 XEmacs/xemacs/src/lrecord.h
Index: lrecord.h
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/lrecord.h,v
retrieving revision 1.41
retrieving revision 1.42
diff -u -p -r1.41 -r1.42
--- lrecord.h 2005/10/25 08:32:48 1.41
+++ lrecord.h 2005/10/26 13:01:42 1.42
@@ -1373,7 +1373,8 @@ enum lrecord_type
Note: Object types defined in external dynamically-loaded modules (not
part of the XEmacs main source code) should use DECLARE_EXTERNAL_LRECORD
and DEFINE_EXTERNAL_LRECORD_IMPLEMENTATION rather than DECLARE_LRECORD
-and DEFINE_LRECORD_IMPLEMENTATION.
+and DEFINE_LRECORD_IMPLEMENTATION. The EXTERNAL versions declare and
+allocate an enumerator for the type being defined.
*/
1.15 +1 -2 XEmacs/xemacs/modules/ldap/eldap.c
Index: eldap.c
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/modules/ldap/eldap.c,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -p -r1.14 -r1.15
--- eldap.c 2005/10/25 08:32:42 1.14
+++ eldap.c 2005/10/26 13:01:45 1.15
@@ -619,7 +619,6 @@ containing attribute/value string pairs.
int i, j;
Elemcount len;
- Lisp_Object current = Qnil;
Lisp_Object values = Qnil;
struct gcpro gcpro1;
@@ -720,7 +719,7 @@ or `replace'. ATTR is the LDAP attribute
Elemcount len;
Lisp_Object values = Qnil;
- struct gcpro gcpro1, gcpro2;
+ struct gcpro gcpro1;
/* Do all the parameter checking */
CHECK_LIVE_LDAP (ldap);