1 new commit in XEmacs: https://bitbucket.org/xemacs/xemacs/commits/d3e0eec3a508/ Changeset: d3e0eec3a508 User: kehoea Date: 2017-09-23 10:18:46+00:00 Summary: Return a Bytecount, read_process_output(), no need for bytecount_to_charcount() src/ChangeLog addition: 2017-09-23 Aidan Kehoe <kehoea(a)parhasard.net&gt; * process.c (read_process_output): Have this return a Bytecount, not a Charcount; the precise number of characters wasn't used by our callers, so we were usually calling bytecount_to_charcount() for no reason. * process.h: Update the declaration of this function. Affected #: 3 files diff -r 8dea4d0549ac0a49456d01bba96171399456c227 -r d3e0eec3a5082a28cdff11a9e5629b076abd4a17 src/ChangeLog --- a/src/ChangeLog +++ b/src/ChangeLog ＠＠ -1,3 +1,11 ＠＠ +2017-09-23 Aidan Kehoe <kehoea(a)parhasard.net&gt; + + * process.c (read_process_output): Have this return a Bytecount, + not a Charcount; the precise number of characters wasn't used by + our callers, so we were usually calling bytecount_to_charcount() + for no reason. + * process.h: Update the declaration of this function. + 2017-06-28 Aidan Kehoe <kehoea(a)parhasard.net&gt; * text.c (Fchar_width): diff -r 8dea4d0549ac0a49456d01bba96171399456c227 -r d3e0eec3a5082a28cdff11a9e5629b076abd4a17 src/process.c --- a/src/process.c +++ b/src/process.c ＠＠ -1079,17 +1079,16 ＠＠ /* Read pending output from the process channel, starting with our buffered-ahead character if we have one. - Yield number of characters read. + Yield number of bytes read. This function reads at most 1024 bytes. If you want to read all available subprocess output, you must call it repeatedly until it returns zero. */ - -Charcount +Bytecount read_process_output (Lisp_Object process, int read_stderr) { /* This function can GC */ - Bytecount nbytes, nchars; + Bytecount nbytes; Ibyte chars[1025]; Lisp_Object outstream; Lisp_Process *p = XPROCESS (process); ＠＠ -1139,16 +1138,16 ＠＠ /* !!#### if the coding system changed as a result of reading, we need to change the output coding system accordingly. */ - nchars = bytecount_to_charcount (chars, nbytes); outstream = filter; if (!NILP (outstream)) { /* Some FSF junk with running_asynch_code, to preserve the match data. Not necessary because we don't call process filters asynchronously (i.e. from within QUIT). */ - /* Don't catch errors here; we're not in any critical code. */ + /* Don't catch errors here; we're not in any critical code. call2() will + GCPRO() the string argument. */ call2 (outstream, process, make_string (chars, nbytes)); - return nchars; + return nbytes; } /* If no filter, write into buffer if it isn't dead. */ ＠＠ -1177,7 +1176,8 ＠＠ unbind_to (spec); UNGCPRO; } - return nchars; + + return nbytes; } int diff -r 8dea4d0549ac0a49456d01bba96171399456c227 -r d3e0eec3a5082a28cdff11a9e5629b076abd4a17 src/process.h --- a/src/process.h +++ b/src/process.h ＠＠ -99,7 +99,7 ＠＠ void status_notify (void); void kick_status_notify (void); void deactivate_process (Lisp_Object proc); -Charcount read_process_output (Lisp_Object proc, int read_stderr); +Bytecount read_process_output (Lisp_Object proc, int read_stderr); int process_has_separate_stderr (Lisp_Object proc); const char *signal_name (int signum); Lisp_Object canonicalize_host_name (Lisp_Object host); Repository URL: https://bitbucket.org/xemacs/xemacs/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.