9:18 a.m.
Accidentally I noticed that 'make-charset' doesn't handle a property
'short-name' correctly.
Here is a patch for that.
Index: mule-charset.c
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs/src/mule-charset.c,v
retrieving revision 1.19
diff -u -r1.19 mule-charset.c
--- mule-charset.c 2001/04/12 18:24:03 1.19
+++ mule-charset.c 2001/04/25 08:03:28
＠＠ -693,7 +693,7 ＠＠
short_name = value;
}
- if (EQ (keyword, Qlong_name))
+ else if (EQ (keyword, Qlong_name))
{
CHECK_STRING (value);
long_name = value;
--
Yoshiaki Kasahara
Computing and Communications Center, Kyushu University
kasahara(a)nc.kyushu-u.ac.jp
2:27 p.m.
Excuse me, would someone please respond ? Is this patch pointless??
On Wed, 25 Apr 2001 17:18:37 +0900 (JST),
Yoshiaki Kasahara <kasahara(a)nc.kyushu-u.ac.jp> said:
Accidentally I noticed that 'make-charset' doesn't handle
a property
'short-name' correctly.
Here is a patch for that.
Index: mule-charset.c
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs/src/mule-charset.c,v
retrieving revision 1.19
diff -u -r1.19 mule-charset.c
--- mule-charset.c 2001/04/12 18:24:03 1.19
+++ mule-charset.c 2001/04/25 08:03:28
＠＠ -693,7 +693,7 ＠＠
short_name = value;
}
- if (EQ (keyword, Qlong_name))
+ else if (EQ (keyword, Qlong_name))
{
CHECK_STRING (value);
long_name = value;
--
Yoshiaki Kasahara
Computing and Communications Center, Kyushu University
kasahara(a)nc.kyushu-u.ac.jp
5:37 a.m.
Yoshiaki Kasahara <kasahara(a)nc.kyushu-u.ac.jp> writes:
Excuse me, would someone please respond ? Is this patch pointless??
Sorry, I've been away for a while.
> Index: mule-charset.c
> ===================================================================
> RCS file: /usr/CVSroot/XEmacs/xemacs/src/mule-charset.c,v
> retrieving revision 1.19
> diff -u -r1.19 mule-charset.c
> --- mule-charset.c 2001/04/12 18:24:03 1.19
> +++ mule-charset.c 2001/04/25 08:03:28
> ＠＠ -693,7 +693,7 ＠＠
> short_name = value;
> }
>
> - if (EQ (keyword, Qlong_name))
> + else if (EQ (keyword, Qlong_name))
> {
> CHECK_STRING (value);
> long_name = value;
>
This patch is correct. Please send it to xemacs-patches
with ChangeLog entry. However, I think XEmacs handles
sort-name properly since both (EQ (keyword, Qshort_name))
and (EQ (keyword, Qlong_name)) will never be true at the
same time. It's just a little bit of performance loss if a
compiler is not smart enough. But it's definitely a good
thing to improve the readability of source code.
--
Yoshiki Hayashi
6:35 a.m.
On 08 May 2001 13:37:41 +0900,
Yoshiki Hayashi <yoshiki(a)xemacs.org> said:
This patch is correct. Please send it to xemacs-patches
with ChangeLog entry.
Ok, I'll try...
However, I think XEmacs handles
sort-name properly since both (EQ (keyword, Qshort_name))
and (EQ (keyword, Qlong_name)) will never be true at the
same time.
Well, I believe that if keyword is 'short_name', the control flow will
go through to final 'else' phrase and cause signal_simple_error().
--
Yoshiaki Kasahara
Computing and Communications Center, Kyushu University
kasahara(a)nc.kyushu-u.ac.jp
7:02 a.m.
Yoshiaki Kasahara <kasahara(a)nc.kyushu-u.ac.jp> writes:
> However, I think XEmacs handles
> sort-name properly since both (EQ (keyword, Qshort_name))
> and (EQ (keyword, Qlong_name)) will never be true at the
> same time.
Well, I believe that if keyword is 'short_name', the control flow will
go through to final 'else' phrase and cause signal_simple_error().
Doh! Thanks for explanation.
--
Yoshiki Hayashi
8:36 a.m.
>>>> "Yoshiki" == Yoshiki Hayashi
<yoshiki(a)xemacs.org> writes:
Yoshiki> But it's definitely a good thing to improve the
Yoshiki> readability of source code.
OK, so that means there's no behavior problem and I _don't_ apply to 21.4?
--
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Institute of Policy and Planning Sciences Tel/fax: +81 (298) 53-5091
_________________ _________________ _________________ _________________
What are those straight lines for? "XEmacs rules."
8382
days inactive
8395
days old
5 comments
3 participants
participants (3)
-
Stephen J. Turnbull -
Yoshiaki Kasahara -
Yoshiki Hayashi