7:22 p.m.
On Mon, 2005-01-17 at 19:07 +0900, Stephen J. Turnbull wrote:
APPROVE COMMIT 21.5 RECOMMEND 21.4
Ville, thanks for snuffling this out.
Thank you for the review and the changelog :)
Malcolm, there may be a similar problem in event-gtk.h; I don't
understand GTK well enough to guess. I don't recall such reports for
GTK builds, but they're not as common as Xt builds so that may not
mean much. Ville, would you be able to check whether this occurs with
a GTK build, with and without your patch?
Checked, it occurs on both patched and unpatched GTK build of 21.4.16
here.
event-gtk.h does not seem to exist in 21.4. Anyway, I dug around a bit
and found that in my GTK headers the only place where Xutil.h is
included is <gdk/gdkprivate.h> which is pulled in only through
<gdk/gdkx.h>. Tried adding some semi-random '#include
<X11/keysym.h>'s
before those gdkx.h's in all src/*-gtk.c (with 21.4.16), but that did
not make the problem go away. I don't have time to look into 21.5 at
the moment, sorry.
1:08 a.m.
New subject: [AC21.5R21.4] AltGr/iso-level3-shift not defined/I-search breakage
>>>> "Ville" == Ville Skytt <Ville>
writes:
Ville> Checked, it occurs on both patched and unpatched GTK build of 21.4.16
Ville> here.
I'll try and look into this but it's hard to reproduce on my hardware. Does
anybody know how to enable AltGr on an Apple keyboard, under either MacOS 10.3
or Linux (Xorg)?
Malcolm - Intel free household.
--
Malcolm Purvis <malcolmp(a)xemacs.org>
1:48 a.m.
New subject: [AC21.5R21.4] AltGr/iso-level3-shift not defined/I-search breakage
Ar an t-ochtú lá déag de mí Eanair, scríobh Malcolm Purvis:
I'll try and look into this but it's hard to reproduce on my
hardware.
Does anybody know how to enable AltGr on an Apple keyboard, under either
MacOS 10.3 or Linux (Xorg)?
Run xev, see what keycode some random modifier key on your machine
gives--the button beside the right control key gives 117 for me, for
example, gives the following xev output--and ignore that it’s already bound
to Super_L ;-)--
KeyPress event, serial 27, synthetic NO, window 0x1400001,
root 0x3b, subw 0x0, time 614527435, (618,180), root:(626,222),
state 0x10, keycode 117 (keysym 0xffeb, Super_L), same_screen YES,
XKeysymToKeycode returns keycode: 115
XLookupString gives 0 bytes:
XmbLookupString gives 0 bytes:
XFilterEvent returns: False
Then feed a corresponding string to xmodmap;
echo ’keycode 117 = Super_L’ | xmodmap -
Malcolm - Intel free household.
As such, I suspect your question wasn’t entirely asked because you couldn’t
work it out for yourself :-) .
--
“Ah come on now Ted, a Volkswagen with a mind of its own, driving all over
the place and going mad, if that’s not scary I don’t know what is.”
12:22 p.m.
New subject: [AC21.5R21.4] AltGr/iso-level3-shift not defined/I-search breakage
>>>> "Aidan" == Aidan Kehoe
<kehoea(a)parhasard.net> writes:
Aidan> Then feed a corresponding string to xmodmap;
Aidan> echo 'keycode 117 = Super_L' | xmodmap -
Thanks. I've managed to change the keymap but unfortunately I haven't been
able to reproduce the bug locally.
Nevertheless, I think the patch below should fix the problem for GTK 21.4.
Ville, can you tell me how this goes? If it works I'll submit it properly to
-patches.
> Malcolm - Intel free household.
Aidan> As such, I suspect your question wasn't entirely asked because you
Aidan> couldn't work it out for yourself :-) .
It was chiefly posted because I spent a good 10 minutes wondering what the
heck mod5 mapped to on my keyboard. It also didn't help that Apple's X
server uses the MacOS native keyboard mapping schemes unless you turn off a
number of not-entirely-obvious options. It's default is great for normal use
but not for this kind of stuff.
Malcolm
Index: src/event-gtk.c
===================================================================
RCS file: /pack/xemacscvs/XEmacs/xemacs/src/event-gtk.c,v
retrieving revision 1.2.2.3
diff -u -r1.2.2.3 event-gtk.c
--- src/event-gtk.c 2004/07/07 02:25:56 1.2.2.3
+++ src/event-gtk.c 2005/01/19 12:09:42
＠＠ -94,11 +94,19 ＠＠
void enqueue_gtk_dispatch_event (Lisp_Object event);
+#ifdef GDK_ISO_Lock
#define IS_MODIFIER_KEY(keysym) \
((((keysym) >= GDK_Shift_L) && ((keysym) <= GDK_Hyper_R)) \
+ || (((keysym) >= GDK_ISO_Lock) && \
+ ((keysym) <= GDK_ISO_Last_Group_Lock)) \
|| ((keysym) == GDK_Mode_switch) \
|| ((keysym) == GDK_Num_Lock))
-
+#else
+#define IS_MODIFIER_KEY(keysym) \
+ ((((keysym) >= GDK_Shift_L) && ((keysym) <= GDK_Hyper_R)) \
+ || ((keysym) == GDK_Mode_switch) \
+ || ((keysym) == GDK_Num_Lock))
+#endif
/************************************************************************/
--
Malcolm Purvis <malcolmp(a)xemacs.org>
6:25 p.m.
New subject: [AC21.5R21.4] AltGr/iso-level3-shift not defined/I-search breakage
On Wed, 2005-01-19 at 23:22 +1100, Malcolm Purvis wrote:
Nevertheless, I think the patch below should fix the problem for GTK
21.4.
Ville, can you tell me how this goes? If it works I'll submit it properly to
-patches.
Confirmed, with that patch, AltGr now works as expected here in the GTK
build of 21.4.16 too. Thanks.
7035
days inactive
7037
days old
4 comments
3 participants
participants (3)
-
Aidan Kehoe -
Malcolm Purvis -
Ville Skyttä