Steve> I was wondering if the commit log emails could be generated _without_ Steve> that 2 character left margin? The patch below should fix the problem, but of course it is impossible to test without checking it in. BTW, log_accum is a really nifty script. I recently adapted it for work to sent the log to the corresponding ticket in a GNATS database and it has been very well received. Malcolm Index: log_accum =================================================================== RCS file: /pack/xemacscvs/CVSROOT/log_accum,v retrieving revision 1.66 diff -u -p -r1.66 log_accum --- log_accum 2005/03/20 17:51:45 1.66 +++ log_accum 2005/10/25 12:12:02 ＠＠ -691,14 +691,14 ＠＠ for ($i = 0; ; $i++) { push(＠text, &read_file("$CHANGED_FILE.$i.$id.$cvs_user", "Modified:")); push(＠text, &read_file("$ADDED_FILE.$i.$id.$cvs_user", "Added:")); push(＠text, &read_file("$REMOVED_FILE.$i.$id.$cvs_user", "Removed:")); - push(＠text, " Log:"); - push(＠text, &read_logfile("$LOG_FILE.$i.$id.$cvs_user", " ")); + push(＠text, "Log:"); + push(＠text, &read_logfile("$LOG_FILE.$i.$id.$cvs_user", "")); push(＠mlist_list, &read_file_lines("$MLIST_FILE.$i.$id.$cvs_user")); if ($rcsidinfo == 2) { if (-e "$SUMMARY_FILE.$i.$id.$cvs_user") { - push(＠text, " "); - push(＠text, " Revision Changes Path"); - push(＠text, &read_logfile("$SUMMARY_FILE.$i.$id.$cvs_user", " ")); + push(＠text, ""); + push(＠text, "Revision Changes Path"); + push(＠text, &read_logfile("$SUMMARY_FILE.$i.$id.$cvs_user", "")); } } push(＠text, ""); -- Malcolm Purvis <malcolmp(a)xemacs.org&gt;

Local mirror, local mirror! I'm working on the test. SY> Well, check it in so we can see if it breaks anything. :-) We should give Mike a day or so to stick his oar in. This would be a good time to think about how to get rid of the duplication across xemacs-patches and xemacs-cvs for commit-then-review patches. -- School of Systems and Information Engineering http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Ask not how you can "do" free software business; ask what your business can "do for" free software.

SY> * Stephen J Turnbull <stephen(a)xemacs.org&gt; writes: SY> Is there much to think about? The committer just needs to not SY> post to xemacs-patches. For that to work, we need to make xemacs-cvs required reading for reviewers, or reviewer patches won't get reviewed. But then we have duplication of non-reviewer patches. Worse, it won't be threaded. I'd like to avoid that. The best I've come up with so far is simply to send xemacs-cvs to xemacs-patches. That still gives you the duplication if a patch is approved and committed as-is, but in theory you can skip it easily if you're using a threading MUA. In practice, that probably won't work OOTB because there's no references header, and the xemacs-cvs subject is autogenerated in a rather uninformative way. My commit logs always have an appropriate reference to xemacs-patches in them, but it's annoying to do. -- School of Systems and Information Engineering http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Ask not how you can "do" free software business; ask what your business can "do for" free software.