9:48 p.m.
Uwe:
(if (featurep 'xemacs)
; (font-height (get-face-font 'default))
(font-height (face-font 'default))
(face-attribute 'default :height nil))
and face-attribute is not known to be defined.
Of course not. It's the code that's called when it's not XEmacs.
If XEmacs had it, the conditional wouldn't be needed.
That's not a problem.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
10:08 p.m.
New subject: Bug: get-face-font: Xemacs21.5.29: org-preview-latex-fragment [7.5]
Julian Bradfield wrote:
Uwe:
> (if (featurep 'xemacs)
> ; (font-height (get-face-font 'default))
> (font-height (face-font 'default))
> (face-attribute 'default :height nil))
> and face-attribute is not known to be defined.
Of course not. It's the code that's called when it's not XEmacs.
If XEmacs had it, the conditional wouldn't be needed.
That's not a problem.
I am very much confused. this code is called *when it is* Xemacs.
and when I call it from Xemacs I precisely get the problem that
face-attribute is not known
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
10:13 p.m.
New subject: Bug: get-face-font: Xemacs21.5.29: org-preview-latex-fragment [7.5]
Uwe:
I am very much confused. this code is called *when it is* Xemacs.
and when I call it from Xemacs I precisely get the problem that
face-attribute is not known
When I call the code you put in your message, I get 15 (the height of
my default font).
How exactly do you call the code so as to get an error?
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
11:48 p.m.
New subject: Bug: get-face-font: Xemacs21.5.29: org-preview-latex-fragment [7.5]
On Fri, 27 Jan 2012 23:08:09 +0100
Uwe Brauer <oub(a)mat.ucm.es> wrote:
Julian Bradfield wrote:
> Uwe:
>> (if (featurep 'xemacs)
>> ; (font-height (get-face-font 'default))
>> (font-height (face-font 'default))
>> (face-attribute 'default :height nil))
>> and face-attribute is not known to be defined.
>
> Of course not. It's the code that's called when it's not XEmacs.
> If XEmacs had it, the conditional wouldn't be needed.
> That's not a problem.
I am very much confused. this code is called *when it is* Xemacs.
and when I call it from Xemacs I precisely get the problem that
face-attribute is not known
Only the first line should be called for XEmacs; it is an if/else, not
a straight if.
So for XEmacs it calls (font-height (face-font 'default)) and for GNU
Emacs it calls (face-attribute 'default :height nil).
You may get a compile error that face-attribute is not know, but you
should not get a runtime error.
Cheers,
Sean
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
1:13 p.m.
New subject: Bug: get-face-font: Xemacs21.5.29: org-preview-latex-fragment [7.5]
> On Fri, 27 Jan 2012 18:48:43 -0500, Sean MacLennan
<seanm(a)seanm.ca> wrote:
On Fri, 27 Jan 2012 23:08:09 +0100
Only the first line should be called for XEmacs; it is an if/else,
not
a straight if.
Right, thanks. I (again) confused an _if_ with a _when_
So for XEmacs it calls (font-height (face-font 'default)) and for
GNU
Emacs it calls (face-attribute 'default :height nil).
You may get a compile error that face-attribute is not know, but you
should not get a runtime error.
Well the org-preview-latex-fragment still does not work, but
now I have to debug it carefully.
Uwe
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
1:14 p.m.
New subject: Bug: get-face-font: Xemacs21.5.29: org-preview-latex-fragment [7.5]
> On Fri, 27 Jan 2012 22:13:34 +0000, Julian Bradfield
> <jcb+xeb(a)jcbradfield.org> wrote:
When I call the code you put in your message, I get 15 (the height
of
my default font).
You are right. (I obtain 18) but anyhow
How exactly do you call the code so as to get an error?
I have to debug the whole org-preview-latex-fragment
function.
Uwe
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
1:28 p.m.
New subject: color-values; face-attribute (was: Bug: get-face-font: Xemacs21.5.29: org-preview-latex-fragment [7.5])
> On Fri, 27 Jan 2012 18:48:43 -0500, Sean MacLennan
<seanm(a)seanm.ca> wrote:
The problem seems to be here:
(defun org-dvipng-color (attr)
"Return an rgb color specification for dvipng."
(apply 'format "rgb %s %s %s"
(mapcar 'org-normalize-color
(color-values (face-attribute 'default attr nil)))))
Xemacs complains about color-values and of course face-attribute.
Uwe
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
1:59 p.m.
New subject: Bug: get-face-font: Xemacs21.5.29: org-preview-latex-fragment [7.5]
The problem seems to be here:
(defun org-dvipng-color (attr)
"Return an rgb color specification for dvipng."
(apply 'format "rgb %s %s %s"
(mapcar 'org-normalize-color
(color-values (face-attribute 'default attr nil)))))
Xemacs complains about color-values and of course face-attribute.
Uwe
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
6:12 p.m.
New subject: Bug: get-face-font: Xemacs21.5.29: org-preview-latex-fragment [7.5]
> On Sat, 28 Jan 2012 14:59:23 +0100, Uwe Brauer
<oub(a)mat.ucm.es> wrote:
The problem seems to be here:
(defun org-dvipng-color (attr)
"Return an rgb color specification for dvipng."
(apply 'format "rgb %s %s %s"
(mapcar 'org-normalize-color
(color-values (face-attribute 'default attr nil)))))
Xemacs complains about color-values and of course face-attribute.
It seems that GNU emacs color-values, corresponds to Xemacs
x-color-values, but how should be
GNU emacs
(face-attribute 'default attr nil)
be expressed in Xemacs?
I looked up the help of GNU emacs about face-attribute, but
it is not clear to me which would be the candidate in
Xemacs.
Uwe Brauer
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
7:28 p.m.
New subject: Bug: get-face-font: Xemacs21.5.29: org-preview-latex-fragment [7.5]
On 2012-01-28, Uwe Brauer <oub(a)mat.ucm.es> wrote:
>> On Sat, 28 Jan 2012 14:59:23 +0100, Uwe Brauer
<oub(a)mat.ucm.es> wrote:
> The problem seems to be here:
> (defun org-dvipng-color (attr)
> "Return an rgb color specification for dvipng."
> (apply 'format "rgb %s %s %s"
> (mapcar 'org-normalize-color
> (color-values (face-attribute 'default attr nil)))))
> Xemacs complains about color-values and of course face-attribute.
It seems that GNU emacs color-values, corresponds to Xemacs
x-color-values, but how should be
You could start with
(face-property 'default (intern (substring (symbol-name attr) 1)))
but then there's more to do, because an XEmacs color is a specifier,
not a color name.
So then you want
(color-rgb-components
(face-property 'default (intern (substring (symbol-name attr) 1))))
(Ten minutes with the manual, while cooking risotto.)
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
7:48 p.m.
New subject: Bug: get-face-font: Xemacs21.5.29: org-preview-latex-fragment [7.5]
Uwe Brauer writes:
The problem seems to be here:
(defun org-dvipng-color (attr)
"Return an rgb color specification for dvipng."
(apply 'format "rgb %s %s %s"
(mapcar 'org-normalize-color
(color-values (face-attribute 'default attr nil)))))
Xemacs complains about color-values and of course face-attribute.
And XEmacs is right to complain. This is an org-mode bug. XEmacs
doesn't have `face-attribute', and we will never have a fully
compatible version because our face properties are mostly specifiers,
which GNU doesn't have. Specifiers have a rather different API from
ordinary variables, and that's not going to change.
Dunno about `color-values', maybe we can and should synch that -- but
for now, we don't have it.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
7:48 p.m.
New subject: Bug: get-face-font: Xemacs21.5.29: org-preview-latex-fragment [7.5]
> On Sat, 28 Jan 2012 19:28:56 +0000, Julian Bradfield
<jcb+xeb(a)jcbradfield.org> wrote:
Thanks very much, I would never have found that out.
(face-property 'default (intern (substring (symbol-name attr)
1)))
but then there's more to do, because an XEmacs color is a
specifier,
not a color name.
So then you want
(color-rgb-components
(face-property 'default (intern (substring (symbol-name attr) 1))))
I tried out
(color-instance-rgb-components (custom-face-inherit
'default attr nil))
Which did not work out. After inserting your lines, the org
code works now, but the color is such that the math symbol
cannot been seen. I will try to debug the GNU emacs and
Xemacs code to find out, why they chose different colors,
and read the manual.
(Ten minutes with the manual, while cooking risotto.)
Bon appetite.
Uwe
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
7:54 p.m.
New subject: Bug: get-face-font: Xemacs21.5.29: org-preview-latex-fragment [7.5]
Uwe Brauer writes:
(face-attribute 'default attr nil)
The closest match is `face-property', but that will return a
specifier, not a value, in particular for colors. I doubt that the
third argument is going to work correctly, since in XEmacs it's a
specifier locale (a buffer, window, or frame, or "global"). You could
also try `face-property-instance', which will return a value, but I'm
not sure if it will DTRT in context.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
2:50 p.m.
New subject: Bug: get-face-font: Xemacs21.5.29: org-preview-latex-fragment [7.5]
Uwe:
>> On Sat, 28 Jan 2012 19:28:56 +0000, Julian Bradfield
<jcb+xeb(a)jcbradfield.org> wrote:
Thanks very much, I would never have found that out.
> (face-property 'default (intern (substring (symbol-name attr) 1)))
To be fair, that includes some gratuitous hackery which I wouldn't
have done myself a few months ago, but having to cope with the VM code
finally made me internalize intern.
A more explicit piece of code, which you would come up with just by
reading the manuals, would be:
(face-property 'default (cond
((eq attr :foreground) 'foreground)
((eq attr :background) 'background)))
This is arguably better, because it makes explicit the correspondence
between specific FSFmacs attribute keys and XEmacs properties, without
overgeneralizing to an assumption that it will always work.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
1:54 a.m.
New subject: Bug: get-face-font: Xemacs21.5.29: org-preview-latex-fragment [7.5]
Julian Bradfield writes:
(face-property 'default (cond
((eq attr :foreground) 'foreground)
((eq attr :background) 'background)))
This is arguably better, because it makes explicit the correspondence
between specific FSFmacs attribute keys and XEmacs properties, without
overgeneralizing to an assumption that it will always work.
Well, if it doesn't work, we probably should/have to make it work,
since our defface is supposed to be compatible with Emacs's even if
the underlying implementation is not.
On the other hand, adding `(t (error 'unimplemented "unknown face
property" attr))' in the explicit cond might be a good idea. :-)
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
4469
days inactive
4472
days old
14 comments
4 participants
participants (4)
-
Julian Bradfield -
Sean MacLennan -
Stephen J. Turnbull -
Uwe Brauer