Ilya> The newest version of my patch retained `struct stat;' in Ilya> from "lisp.h" because removing it *may* break compilation on Ilya> windows (never tried it anyway). Why didn't you say that when you sent your patch? I went looking for such problems, but missed that one. Ilya> When "syswindows.h" included in "glyphs-msw.h" included in Ilya> "frame-msw.c", "sysfile.h" is not included before. How will Ilya> "frame-msw.c" compile on windows witout `struct stat;'? Cygwin warns about a declaration in a parameter list, dunno about native. And that's not the only such case, I think. So I'm going to include sysfile.h from syswindows.h. We'll see what comes out tomorrow, I need sleep. -- Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Ask not how you can "do" free software business; ask what your business can "do for" free software.

Ilya> On Tue, 13 May 2003 00:44:37 +0900 "Stephen J. Turnbull" Ilya> <stephen(a)xemacs.org&gt; wrote Ilya> I still do not see such a change in main (21.5) branch. We Ilya> need to decide what to do with it before we try to port the Ilya> `stat' fix in 21.4, as Vin Shelton suggested in Ilya> <m27k8dci9c.fsf(a)zion.rcn.com&gt; on Mon, 26 May 2003 21:04:15 Ilya> -0400. I've had second thoughts. First of all, the problematic case you cite uses struct stat only in an unused declaration. So it's not urgent. Second, it's not obvious to me that the declarations of file-related functions don't belong somewhere else besides syswindows.h. -- Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Ask not how you can "do" free software business; ask what your business can "do for" free software.