5:27 a.m.
These are the current failures from lisp-tests.el. Could somebody
please look into these with the intent to fix the bugs. And if you
could let me know that you are working on this, that would be
fantastic and a great help to me.
The results were obtained on a i586 GNU/Linux system by:
xemacs -no-autoloads
M-x load-file RET ./tests/automated/test-harness.el RET
M-x test-emacs-test-file RET ./tests/automated/lisp-tests.el RET
Testing /usr/local/src/xemacs/tests/automated/lisp-tests.el...
Testing Interpreted Lisp
FAIL: Assertion failed: (equal (split-string ",foo,bar," ",") (quote
("" "foo" "bar" "")))
FAIL: Assertion failed: (equal (split-string ",foo,bar," "^,") (quote
("" "foo,bar,")))
FAIL: Assertion failed: (equal (split-string ",foo,bar," ",$") (quote
(",foo,bar" "")))
FAIL: Assertion failed: (equal (split-string ",foo,,bar," ",") (quote
("" "foo" "" "bar" "")))
FAIL: Assertion failed: (equal (split-string "foo,,bar,," ",") (quote
("foo" "" "bar" "" "")))
FAIL: Assertion failed: (equal (split-string ",foo,,bar," ",+") (quote
("" "foo" "bar" "")))
Testing Compiled Lisp
FAIL: Assertion failed: (equal (split-string ",foo,bar," ",") (quote
("" "foo" "bar" "")))
FAIL: Assertion failed: (equal (split-string ",foo,bar," "^,") (quote
("" "foo,bar,")))
FAIL: Assertion failed: (equal (split-string ",foo,bar," ",$") (quote
(",foo,bar" "")))
FAIL: Assertion failed: (equal (split-string ",foo,,bar," ",") (quote
("" "foo" "" "bar" "")))
FAIL: Assertion failed: (equal (split-string "foo,,bar,," ",") (quote
("foo" "" "bar" "" "")))
FAIL: Assertion failed: (equal (split-string ",foo,,bar," ",+") (quote
("" "foo" "bar" "")))
SUMMARY for /usr/local/src/xemacs/tests/automated/lisp-tests.el:
3594 passes
12 assertion failures
0 errors that should have been generated, but weren't
0 wrong-error failures
0 missing-message failures
0 other failures
--
|---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|
4:49 p.m.
Steve Youngs <youngs(a)xemacs.org> wrote:
Testing Interpreted Lisp
FAIL: Assertion failed: (equal (split-string ",foo,bar," ",") (quote
("" "foo" "bar" "")))
FAIL: Assertion failed: (equal (split-string ",foo,bar," "^,") (quote
("" "foo,bar,")))
FAIL: Assertion failed: (equal (split-string ",foo,bar," ",$") (quote
(",foo,bar" "")))
FAIL: Assertion failed: (equal (split-string ",foo,,bar," ",") (quote
("" "foo" "" "bar" "")))
FAIL: Assertion failed: (equal (split-string "foo,,bar,," ",") (quote
("foo" "" "bar" "" "")))
FAIL: Assertion failed: (equal (split-string ",foo,,bar," ",+")
(quote ("" "foo" "bar" "")))
Testing Compiled Lisp
FAIL: Assertion failed: (equal (split-string ",foo,bar," ",") (quote
("" "foo" "bar" "")))
FAIL: Assertion failed: (equal (split-string ",foo,bar," "^,") (quote
("" "foo,bar,")))
FAIL: Assertion failed: (equal (split-string ",foo,bar," ",$") (quote
(",foo,bar" "")))
FAIL: Assertion failed: (equal (split-string ",foo,,bar," ",") (quote
("" "foo" "" "bar" "")))
FAIL: Assertion failed: (equal (split-string "foo,,bar,," ",") (quote
("foo" "" "bar" "" "")))
FAIL: Assertion failed: (equal (split-string ",foo,,bar," ",+")
(quote ("" "foo" "bar" "")))
These stem from Ben's recent synch with FSF Emacs:
<URL:http://list-archive.xemacs.org/xemacs-patches/200303/msg00004.html>;.
They apparently decided to do away with including empty strings at the
beginning and end of the list if the string starts or ends with a
separator (see the docstring). We need to decide whether we want the
old behavior, in which case split-string needs to be fixed, or the new
behavior, in which case the tests need to be fixed.
--
Jerry James
http://www.ittc.ku.edu/~james/
12:24 a.m.
|--==> "JJ" == Jerry James <james(a)xemacs.org> writes:
JJ> Steve Youngs <youngs(a)xemacs.org> wrote:
>FAIL: Assertion failed: (equal (split-string ",foo,bar,"
",") (quote ("" "foo" "bar" "")))
>FAIL: Assertion failed: (equal (split-string ",foo,bar," "^,")
(quote ("" "foo,bar,")))
>FAIL: Assertion failed: (equal (split-string ",foo,bar," ",$")
(quote (",foo,bar" "")))
>FAIL: Assertion failed: (equal (split-string ",foo,,bar," ",")
(quote ("" "foo" "" "bar" "")))
>FAIL: Assertion failed: (equal (split-string "foo,,bar,," ",")
(quote ("foo" "" "bar" "" "")))
>FAIL: Assertion failed: (equal (split-string ",foo,,bar," ",+")
(quote ("" "foo" "bar" "")))
JJ> These stem from Ben's recent synch with FSF Emacs:
JJ> <URL:http://list-archive.xemacs.org/xemacs-patches/200303/msg00004.html>;.
JJ> They apparently decided to do away with including empty strings at the
JJ> beginning and end of the list if the string starts or ends with a
JJ> separator (see the docstring). We need to decide whether we want the
JJ> old behavior, in which case split-string needs to be fixed, or the new
JJ> behavior, in which case the tests need to be fixed.
Ben, can you comment on this.
My feeling is that if `split-string' works as advertised, we fix the
tests. But I'd like to wait to find out what Ben thinks.
--
|---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|
4:01 a.m.
Steve Youngs <youngs(a)xemacs.org> wrote:
|--==> "JJ" == Jerry James <james(a)xemacs.org>
writes:
JJ> These stem from Ben's recent synch with FSF Emacs:
JJ> <URL:http://list-archive.xemacs.org/xemacs-patches/200303/msg00004.html>;.
JJ> They apparently decided to do away with including empty strings at the
JJ> beginning and end of the list if the string starts or ends with a
JJ> separator (see the docstring). We need to decide whether we want the
JJ> old behavior, in which case split-string needs to be fixed, or the new
JJ> behavior, in which case the tests need to be fixed.
Ben, can you comment on this.
My feeling is that if `split-string' works as advertised, we fix the
tests. But I'd like to wait to find out what Ben thinks.
I haven't heard from Ben, so I did a little snooping through the Lisp
code that we ship (both in the lisp directory and in packages). In most
of the cases where I understood what was going on, it looked like the
empty strings would never be generated anyway. There were a few
functions that immediately deleted any empty strings in the result. The
one case that left me wondering is BBDB. It possibly depends on the old
behavior (see especially bbdb-get-field in bbdb.el), but I'm not sure.
Is anybody familiar enough with BBDB's inner workings to tell?
Incidentally, quite a few packages have their own split-string
functions, almost all identical (APEL, AUCTeX, clearcase, dictionary,
and EUDC to name a few). I don't know that we need to do anything about
it, necessarily.
If BBDB is not a problem or can be fixed easily, I propose that we patch
the tests to make them conform to the new behavior.
--
Jerry James
http://www.ittc.ku.edu/~james/
5:19 a.m.
>>>> "Jerry" == Jerry James
<james(a)xemacs.org> writes:
Jerry> If BBDB is not a problem or can be fixed easily, I propose
Jerry> that we patch the tests to make them conform to the new
Jerry> behavior.
There are two cases where I really don't like the new behavior, and
that's when SEPARATORS is "\n", and when the target is a csv file.
Especially in the latter case null-string elements of the list are
significant.
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.
10:46 a.m.
>>>> "sjt" == Stephen J Turnbull
<stephen(a)xemacs.org> writes:
>>>> "Jerry" == Jerry James
<james(a)xemacs.org> writes:
Jerry> If BBDB is not a problem or can be fixed easily, I propose
Jerry> that we patch the tests to make them conform to the new
Jerry> behavior.
sjt> There are two cases where I really don't like the new
sjt> behavior, and that's when SEPARATORS is "\n", and when the
sjt> target is a csv file.
sjt> Especially in the latter case null-string elements of the
sjt> list are significant.
OK, I've talked to Ben about it by phone, and he says that he didn't
think about the change in behavior when he did the sync, and that he
agrees that csv is a valid concern. He didn't want to express an
opinion on whether we should sync split-string to GNU and have a
separate function to implement the old behavior, or not sync.
I personally think that
(split-string ",,data,," ",") => ("" "data"
"")
is extremely bogus behavior. I can't imagine ever wanting that, while
the idiom (delete "" (split-string ",,data,," ",")) is very
natural.
Python uses the old XEmacs behavior, Perl preserves the leading empty
field but strips _all_ trailing empty fields (not just the last one)
by default, but this can be modified to preserve all empty fields.
Perl's split cannot be induced to give the GNU behavior.
However, I can't find discussion of this change in the ML archives at
savannah.gnu.org. That means it must be ancient. Since we haven't
had thousands of new recruits coming because they're disgusted with
the behavior of GNU Emacs split-string, I guess if people want to sync
to GNU behavior, I'll just add a separate function
(split-string-sanely, I think I'll call it ;-).
BTW, Ben is buried in email and snail mail, slowly digging his way
out. He says he'll try to answer personal mail more quickly.
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.
7676
days inactive
7702
days old
5 comments
3 participants
participants (3)
-
Jerry James -
Stephen J. Turnbull -
Steve Youngs