3:06 p.m.
This report is for f9e59cd39a9a+ using —with-union-type. Removing that
directive from configure allows compilation and linking to succeed. I
have not compiled Emacs-beta since January 2015, so I cannot say which
of the change sets in February or March caused the problem. Note that
I use clang to compile. I do not have a real gcc installed any longer.
clang -c -Wall -Wno-switch -Wundef -Wsign-compare -Wno-char-subscripts
-Wpacked -Wpointer-arith -Wshadow -Wmissing-declarations
-Wmissing-prototypes -Wstrict-prototypes -Wdeclaration-after-statement
-Wunused-parameter -g -arch x86_64 -g -I/opt/local/include
-I/opt/X11/include -I/opt/X11/include/freetype2 -Demacs -I.
-I/Users/royar/src/xemacs-hg/src -DHAVE_CONFIG_H -I/opt/X11/include
-I/opt/X11/include/freetype2 -I/opt/X11/include -I/opt/X11/include
data.c
data.c:1520:17: error: assigning to 'Lisp_Object' (aka 'union
Lisp_Object') from incompatible type 'long'
highest_value = XFIXNUM (XCHAR_TABLE (radix_table)->default_);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[1]: *** [data.o] Error 1
make: *** [src] Error 2
My environment is an iMac OS X 10.10.2 27 inch Retina 5K machine with
the following characteristics
uname -a: Darwin grendel.frinabulax.org 14.1.0 Darwin Kernel Version
14.1.0: Mon Dec 22 23:10:38 PST 2014;
root:xnu-2782.10.72~2/RELEASE_X86_64 x86_64 i386 iMac15,1 Darwin
./configure '--with-mule' '--with-gcc'
'--with-scrollbars=athena'
'--with-widgets=athena' '--with-athena=3d'
'--with-dialogs=athena'
'--prefix=/Users/royar/usr/local' '--with-png' '--with-xim=no'
'--without-xfs' '--with-compiler=clang' '--with-pdump'
'--disable-kkcc' '--without-ipv6-cname' '--without-ldap'
'--without-postgresql' '--x-includes=/opt/X11/include'
'--x-libraries=/opt/X11/lib' '--with-xft=emacs,gauges,tabs'
'--with-union-type' '--without-error-checking' '--with-dynamic'
'--enable-dump-in-exec' '--without-tls' 'CC=/usr/bin/clang'
'CFLAGS=-arch x86_64 -g' 'LDFLAGS=-L/usr/lib -lncurses -lz
-L/opt/X11/lib -lpng -lXpm -lXft -lXrender -lXt -lXext -lX11 -lSM
-lICE -lfontconfig -L/opt/local/lib -ltiff -ljpeg'
'CPPFLAGS=-I/opt/local/include -I/opt/X11/include
-I/opt/X11/include/freetype2' 'CXX=/usr/bin/clang++'
XEmacs 21.5-b34 "kale" f9e59cd39a9a+ configured for
`x86_64-apple-darwin14.1.0'.
Compilation Environment and Installation Defaults:
Source code location: /Users/royar/src/xemacs-hg
Installation prefix: /Users/royar/usr/local
Not using any operating system description file
Not using any machine description file
Compiler version: Apple LLVM version 6.0
(clang-600.0.57) (based on LLVM 3.5svn)
- GCC specs file: 3.5svn)
- Compiler command: clang -Wall -Wno-switch -Wundef
-Wsign-compare -Wno-char-subscripts -Wpacked -Wpointer-arith -Wshadow
-Wmissing-declarations -Wmissing-prototypes -Wstrict-prototypes
-Wdeclaration-after-statement -Wunused-parameter -g -arch x86_64 -g
libc version:
Relocating allocator for buffers: no
GNU version of malloc: no
- The GNU allocators don't work with this system configuration.
--
Robert Royar <xemacs(a)royar.org>
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
5:12 a.m.
Robert Royar writes:
This report is for f9e59cd39a9a+ using —with-union-type.
data.c:1520:17: error: assigning to 'Lisp_Object' (aka
'union
Lisp_Object') from incompatible type 'long'
highest_value = XFIXNUM (XCHAR_TABLE (radix_table)->default_);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Thanks for the report, and sorry for the trouble. This probably is a
genuine bug (divides by 2 in a non-union-type build!)
This is probably one of Aidan's recent patches (better numeral
parsing, I think), as I use --with-union-type on Mac/Clang myself and
haven't had this problem yet, but haven't rebuilt since his recent
spate of patches.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
6:11 a.m.
>>>> Stephen J Turnbull <stephen(a)xemacs.org> writes:
This is probably one of Aidan's recent patches (better numeral
parsing, I think), as I use --with-union-type on Mac/Clang myself and
haven't had this problem yet, but haven't rebuilt since his recent
spate of patches.
Yes. The buildbot has been reporting failed builds since this change:
http://www.lidell.nu/xemacs-buildbot/changes/503
Yours
--
%% Mats
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
9:23 a.m.
On 19 Mar 2015, at 16:06, Robert Royar <xemacs(a)royar.org>
wrote:
using —with-union-type. Removing that
Hi
I confirm this behavior using kubuntu and gcc
Uwe Brauer
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
2:03 p.m.
New subject: [COMMIT] Don't extract a fixnum value unnecessarily, thank you Robert Delius Royar
Ar an naoú lá déag de mí Márta, scríobh Robert Royar:
This report is for f9e59cd39a9a+ using —with-union-type. Removing
that
directive from configure allows compilation and linking to succeed. I
have not compiled Emacs-beta since January 2015, so I cannot say which
of the change sets in February or March caused the problem. Note that
I use clang to compile. I do not have a real gcc installed any longer.
clang -c -Wall -Wno-switch -Wundef -Wsign-compare -Wno-char-subscripts
-Wpacked -Wpointer-arith -Wshadow -Wmissing-declarations
-Wmissing-prototypes -Wstrict-prototypes -Wdeclaration-after-statement
-Wunused-parameter -g -arch x86_64 -g -I/opt/local/include
-I/opt/X11/include -I/opt/X11/include/freetype2 -Demacs -I.
-I/Users/royar/src/xemacs-hg/src -DHAVE_CONFIG_H -I/opt/X11/include
-I/opt/X11/include/freetype2 -I/opt/X11/include -I/opt/X11/include
data.c
data.c:1520:17: error: assigning to 'Lisp_Object' (aka 'union
Lisp_Object') from incompatible type 'long'
highest_value = XFIXNUM (XCHAR_TABLE (radix_table)->default_);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[1]: *** [data.o] Error 1
make: *** [src] Error 2
My mistake, thank you for the report, Robert! I’ve committed a change that
addresses this locally, and pushed, if you have a few minutes I’d appreciate
confirmation that it works for you.
Best,
Aidan
APPROVE COMMIT
NOTE: This patch has been committed
# HG changeset patch
# User Aidan Kehoe <kehoea(a)parhasard.net>
# Date 1426859296 0
# Fri Mar 20 13:48:16 2015 +0000
# Node ID 5a311f1f46aaf7481c34f90d66d4666c3d9838d3
# Parent f9e59cd39a9a3ac98bee0a471a22fda8e0d7c19d
Don't extract a fixnum value unnecessarily, thank you Robert Delius Royar
2015-03-20 Aidan Kehoe <kehoea(a)parhasard.net>
* data.c (build_fixnum_to_char_map):
Whoops, highest_value is a Lisp_Object, no need to extract the
fixnum from radix_table->default_ when initialising it. Thank you
Robert Delius Royar, Uwe Brauer, and the union build.
diff -r f9e59cd39a9a -r 5a311f1f46aa src/ChangeLog
--- a/src/ChangeLog Tue Mar 17 12:22:50 2015 +0000
+++ b/src/ChangeLog Fri Mar 20 13:48:16 2015 +0000
＠＠ -1,3 +1,10 ＠＠
+2015-03-20 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * data.c (build_fixnum_to_char_map):
+ Whoops, highest_value is a Lisp_Object, no need to extract the
+ fixnum from radix_table->default_ when initialising it. Thank you
+ Robert Delius Royar, Uwe Brauer, and the union build.
+
2015-03-17 Aidan Kehoe <kehoea(a)parhasard.net>
* data.c (fill_ichar_array):
diff -r f9e59cd39a9a -r 5a311f1f46aa src/data.c
--- a/src/data.c Tue Mar 17 12:22:50 2015 +0000
+++ b/src/data.c Fri Mar 20 13:48:16 2015 +0000
＠＠ -1517,7 +1517,8 ＠＠
/* What's the greatest fixnum value seen? In passing, check all the char
table values are fixnums. */
CHECK_FIXNUM (XCHAR_TABLE (radix_table)->default_);
- highest_value = XFIXNUM (XCHAR_TABLE (radix_table)->default_);
+ highest_value = XCHAR_TABLE (radix_table)->default_;
+
map_char_table (radix_table, &ctr, find_highest_value, &highest_value);
cclen = XFIXNUM (highest_value) + 1;
--
‘Tramadol is further fed to cattle […] when working them […] (as draft
animals) so that the animals do not get tired quickly. …’
— Angewandte Chemie, Sept 2014, describing the social context of
(synthetic) tramadol having been found in Cameroon tree roots.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
3324
days inactive
3325
days old
4 comments
5 participants
participants (5)
-
Aidan Kehoe -
Robert Royar -
Stephen J. Turnbull -
The XEmacs Package Smoketest -
Uwe Brauer