3:06 a.m.
I saw this fix that was posted on comp.emacs.xemacs in December 2007.
It doesn't appear to have been applied yet. It fixes a bug that I
introduced in 2002-01-16. Mea culpa!
7:36 p.m.
John Paul Wallington writes:
I saw this fix that was posted on comp.emacs.xemacs in December 2007.
In "man.el" there is the following customization of
variable "Manual-
switches"
(defcustom Manual-switches nil
"List of switches to the man program."
:type '(choice (list (string :tag "switches"))
(const :tag "none" nil))
:group 'man)
Changing the customization to:
(defcustom Manual-switches nil
"List of switches to the man program."
:type '(choice (const :tag "none" nil)
(repeat (string :tag "switch")))
:group 'man)
The fix is obviously correct, and I will apply it shortly, but is
there a reason for putting the "none"/nil choice first? I tend to
favor putting the "no customizations"/nil last.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
11:09 p.m.
On 26 Apr 2008, at 19:36, Stephen J. Turnbull wrote:
The fix is obviously correct, and I will apply it shortly, but is
there a reason for putting the "none"/nil choice first? I tend to
favor putting the "no customizations"/nil last.
I guess the variable's default value, nil, matches both the const nil
form and the repeat string form. If the customize interface shows the
first applicable choice then it would be necessary to put the const
nil choice first lest it be redundant.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
11:59 p.m.
John Paul Wallington writes:
I guess the variable's default value, nil, matches both the const
nil
form and the repeat string form. If the customize interface shows the
first applicable choice then it would be necessary to put the const
nil choice first lest it be redundant.
D'oh. It *is* redundant, isn't it. Unless somebody comes up with a
good reason not to, I'm just going to get rid of the const nil and
parent choice widget, too.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
1:18 p.m.
On 27 Apr 2008, at 23:59, Stephen J. Turnbull wrote:
D'oh. It *is* redundant, isn't it. Unless somebody comes up
with a
good reason not to, I'm just going to get rid of the const nil and
parent choice widget, too.
FWIW, although it's strictly redundant I think offering the choice
makes for a better user experience and would leave Alan's patch as-is.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
12:09 p.m.
New subject: [COMMIT] Allow Manual-switches to be set sensibly
Thank you Alan, and thank you John Paul!
APPROVE COMMIT
NOTE: This patch has been committed.
xemacs-packages/edit-utils/ChangeLog addition:
2008-04-27 Aidan Kehoe <kehoea(a)parhasard.net>
* man.el (Manual-switches): Incorporate Alan Wehmann's fix of
1edd28c6-438e-4cd5-be3e-c819a7044da4(a)o42g2000hsc.googlegroups.com
to allow Manual-switches to be set sensibly. Thank you Alan, and
thank you John Paul Wallington!
XEmacs Packages source patch:
Diff command: cvs -q diff -Nu
Files affected: xemacs-packages/edit-utils/man.el
===================================================================
RCS
Index: xemacs-packages/edit-utils/man.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/edit-utils/man.el,v
retrieving revision 1.18
diff -u -u -r1.18 man.el
--- xemacs-packages/edit-utils/man.el 2005/02/08 23:26:06 1.18
+++ xemacs-packages/edit-utils/man.el 2008/04/27 11:07:04
＠＠ -51,8 +51,8 ＠＠
(defcustom Manual-switches nil
"List of switches to the man program."
-:type '(choice (list (string :tag "switches"))
- (const :tag "none" nil))
+:type '(choice (const :tag "none" nil)
+ (repeat (string :tag "switch")))
:group 'man)
(defcustom Manual-mode-hook nil
--
¿Dónde estará ahora mi sobrino Yoghurtu Nghé, que tuvo que huir
precipitadamente de la aldea por culpa de la escasez de rinocerontes?
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
5836
days inactive
5838
days old
5 comments
3 participants
participants (3)
-
Aidan Kehoe -
John Paul Wallington -
Stephen J. Turnbull