>>>> "mb" == Martin Buchholz
<martin(a)xemacs.org> writes:
mb> Although I love configure, I don't love adding new configure
mb> tests. So I asked myself if this could be done only using cpp
mb> (I also love cpp!). And I think so.
It can. I suggested something nearly identical in my first response
to Edwin's patch. Not tested though.
mb> This only requires, for complete safety, that the nas headers
mb> are included last.
... and that nobody who know how to use the standard *_ENDIAN macros
ever does so in this file. But audio is a field where people do check
endianess.
I am not able to assess the likelihood of that so I went with slightly
safer code that will increase its advantage as NAS >= 1.4 becomes
prevalent. If you judge that that risk is very low, you can munge the
*_ENDIAN macros freely. But such a mistake cannot possibly be caught
by the compiler. My code can't catch the mistake either for NAS <=
1.2p5, but code using *_ENDIAN will work as expected for NAS >= 1.4.
I agree that your code is simpler, and should work. If you say you
want it that way, I'll write it and test it (I can test XEmacs 21.1
and 21.2, NAS 1.2p5 and 1.4 without too much trouble), then submit
patch(es).
--
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Institute of Policy and Planning Sciences Tel/fax: +81 (298) 53-5091
_________________ _________________ _________________ _________________
What are those straight lines for? "XEmacs rules."