Re: [R] Port `move-beginning-of-line', `move-end-of-line' from GNU Emacs
Ar an deichiú lá de mí na Nollaig, scríobh Stephen J. Turnbull:
[...] `string-match-p' uses `match-data' and
`store-match-data' rather
than `save-match-data' (may be safer since it uses an unwind-protect).
I agree with your other points, in general, but this is wrong, since
#'string-match is explicitly documented to preserve the match data on
failure, and it is the only function called, there is no safety improvement
from #'save-match-data here.
`add-to-history' is broken, it uses delete on a list without a
set. N.B.
The relevant sexp in our `read-from-minibuffer' does it right. I'm also
not sure I agree with `add-to-history's logic, but it's not too bad, and
I think I know how to improve it bug-compatibly.
I'll try to get around to fixing and pushing by the weekend, but no
promises.
--
‘Liston operated so fast that he once accidentally amputated an assistant’s
fingers along with a patient’s leg, […] The patient and the assistant both
died of sepsis, and a spectator reportedly died of shock, resulting in the
only known procedure with a 300% mortality.’ (Atul Gawande, NEJM, 2012)
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta